[jbosstools-issues] [JBoss JIRA] (JBIDE-21331) Connection wizard: it looks as if the wizard is creating new connection instances several times

[Andre Dietisheim (JIRA)]

Andre Dietisheim created JBIDE-21331:
----------------------------------------

             Summary: Connection wizard: it looks as if the wizard is creating new connection instances several times
                 Key: JBIDE-21331
                 URL: https://issues.jboss.org/browse/JBIDE-21331
             Project: Tools (JBoss Tools)
          Issue Type: Enhancement
          Components: openshift
    Affects Versions: 4.3.1.Beta2
            Reporter: Andre Dietisheim
            Priority: Minor


The connection wizard creates new connection instances in several places which seems unnecessary (we need it at least once where we dont want to modify an existing connection and operate on a copy before merging the changes back upon successfull verification)

{code:title:ConnctionWizardPageModel} 
	private void initEditConnection(IConnection connection) {
		this.selectedConnection = connection;
		this.connection = connection.clone();
		...
{code}

{code:title:ConnctionWizardPageModel} 
	public IStatus connect() {
		...
		try {
			this.connection = createConnection();
		...
{code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)