[jbosstools-issues] [JBoss JIRA] (JBIDE-21340) Deploy from existing project git constraints are too stringent

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142108#comment-13142108 ] 

Andre Dietisheim commented on JBIDE-21340:
------------------------------------------

added new PR against jbosstools-4.3.x https://github.com/jbosstools/jbosstools-openshift/pull/860

Missing: validation of required git source parameter property in ParamterListPage.
To find out what parameter is the git repository url you'd do:
{code}
… public String getGitRepoParameterKey() {
		ITemplate template = model.getSelectedTemplate();
		if (template != null) {
			for(String key : new String[]{"SOURCE_REPOSITORY_URL", "GIT_URI"}) {
				if (template.getParameters().containsKey(key)) {
					return key;
				}
			}
		}
		return null;
	}
{code}



> Deploy from existing project git constraints are too stringent
> --------------------------------------------------------------
>
>                 Key: JBIDE-21340
>                 URL: https://issues.jboss.org/browse/JBIDE-21340
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Fred Bricon
>            Assignee: Andre Dietisheim
>             Fix For: 4.3.1.Beta2
>
>
> There are currently 2 constraints when deploying ane existing project to OpenShift 3 that are really really annoying:
> - if the project is shared with git but dirty, you can't proceed with project deployment on openshift. This constraint is completely unnecessary and should be lifted
> - if the project was cloned using git/ssh protocol, it can't be deployed directly (http(s) is required). This should actually just be a warning, the user can modify the git url to use http(s) in the next page



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)