[jbosstools-issues] [JBoss JIRA] (JBIDE-21233) remove need for a targetplatforms/jbosstoolstarget/neon site

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143749#comment-13143749 ] 

Nick Boldt commented on JBIDE-21233:
------------------------------------

a) the JBT component, JBT aggregate, & JBDS aggregate sites already build against a SPECIFIC TP, as defined in the parent pom or Jenkins config. The composite sites are also generated using SPECIFIC TPs so we maintain total control over which TP is used at build time. Nothing changes there.

b) we never removed the associate sites for JBT. We only removed it for JBDS. This JIRA is concerned with doing the same thing we did for JBDS now for JBT. That's why I'm surprised you're so concerned about making a change for JBT which we all agreed was a benefit to JBDS. 

"Required sites" are the same as "associate sites" as defined in the update site's metadata. We used to use an Ant script (back in 2011) but we ported that to Maven so we can do this:

https://github.com/jbosstools/jbosstools-build-sites/blob/master/aggregate/coretests-site/pom.xml#L30-L35

So, no, I'm not forgetting how we used to do things. If you look at the code in the artifacts.xml you'll see the output is the same as it was in 2011. 

c) No, this doesn't change anything about BUILDING. This only changes the INSTALL experience for users since we'd only be changing the contents of the composite site they use to do the INSTALL. Re: "p2 required sites", see my answer in (b). We do, and I want to remove that because it's no longer needed. 

----

The ONLY benefit having a /targetplatforms/jbosstoolstarget/mars/ composite site provides is to expose a Mars.0 user to a TP with Mars.1 bits so we can encourage them to update to the newer Eclipse / WTP / Egit / m2e / etc. 

But since that's ALSO available in http://download.jboss.org/jbosstools/mars/stable/updates/ because that composite includes our Mars.1 TP, the associate site provides no value except to clutter the Available Software Sites preference page. THAT is why I want to remove it: no value and comes with a maintenance cost.



> remove need for a targetplatforms/jbosstoolstarget/neon site
> ------------------------------------------------------------
>
>                 Key: JBIDE-21233
>                 URL: https://issues.jboss.org/browse/JBIDE-21233
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build, target-platform
>    Affects Versions: 4.4.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.4.0.Alpha1
>
>         Attachments: jbt-creeping-update-sites.png
>
>
> For the last few years, we've had an associate site ref inside the JBT agg site, pointing at "the latest maximum TP", eg., http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/mars/
> But since we now always co-release JBT with its TP in the same URL, this is only useful for someone who wants to do an OFFLINE install using the zip, which will then go ONLINE to resolve TP dependencies. It's at best a broken use case, and at worst it's unnecessary cruft to maintain. 
> Therefore I propose we stop linking to this site.
> We can build the aggregates using a specific TP (the one in the parent pom, natch), and simply NOT use an associate site in the JBT aggregate site build.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)