[jbosstools-issues] [JBoss JIRA] (JBIDE-21122) Port Forwarding: Start All button should be disabled if port forwarding is already active

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144190#comment-13144190 ] 

Viacheslav Kabanovich commented on JBIDE-21122:
-----------------------------------------------

1. It seems that 2 independent binds to model for startButton (as well as for findFreesPortButton) does not work as planned.
I added a new property to model "portForwardingAllowed" that computes value as needed for startButton and findFreesPortButton and bound them to it. Maybe it is not the only way to solve the problem, but I find it appealing to have one simple property that implements the entire logic inside the model.

2. Since getPortForwarding() is based on REGISTRY, and computed in startPortForwarding() portForwardable object is added to REGISTRY _after_ call pod.accept(), firing property change inside visit() seems has no effect, so that I copied firing to the end of startPortForwarding().

[~jcantrill], [~fbricon], please take a look at the pull request.

> Port Forwarding: Start All button should be disabled if port forwarding is already active
> -----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21122
>                 URL: https://issues.jboss.org/browse/JBIDE-21122
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Marián Labuda
>              Labels: openshift_v3, port_forwarding_wizard
>             Fix For: 4.3.1.Beta2
>
>
> In Port Forwarding wizard is a button "Start All" which starts port forwarding for all services listed in a table. If user triggers the button and port forwarding is already active, Start All is still enabled and user can click on it again and again but nothing happens. Accessibility of this button should be similar as Stop All, which works as expected - if port forwarding is not active, it is disabled, otherwise it is enabled.
> There is also a checkbox to find free ports for port forwarding. Once port forwarding is active, checking and unchecking this checkbox do nothing. It should have same accessibility as Start All button - if there is active port forwarding, the checkbox should be disabled, otherwise it should be enabled.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)