[jbosstools-issues] [JBoss JIRA] (JBIDE-18709) EAP alpha releases not require credentials; verify downloadRuntimes works

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038296#comment-13038296 ] 

Rob Stryker commented on JBIDE-18709:
-------------------------------------

I've tested our current tools with the following URLs:

http://www.jboss.org/download-manager/file/jboss-eap-6.4.0.Alpha.zip

http://www.jboss.org/download-manager/jdf/file/jboss-eap-6.4.0.Alpha.zip

 I had to add the following to a local stacks.yaml:

{code}
   #####################
   #   E A P 6.4       #
   #####################

 - &jbosseap640runtime
   id: jbosseap640runtime
   name: JBoss EAP 6.4.0
   version: 6.4.0
   license: *lgpl21
   url: http://www.jboss.org/products
   downloadUrl: http://www.jboss.org/download-manager/jdf/file/jboss-eap-6.4.0.Alpha.zip
#  deleted bom stuff
   labels: {
        requiresCredentials: true,
        runtime-category: SERVER,
        runtime-type: EAP,
        runtime-size: 158177216,
        wtp-runtime-type: org.jboss.ide.eclipse.as.runtime.eap.61
   } 
{code}


The non-jdf request failed and only downloaded an html page.   The jdf URL worked.  Our tools still required credentials, even though technically we don't need them.   But if you note above, we still have requiresCredentials=true.   This is to ensure that our tools make a request with the proper JDF request parameters, like an xml / json  request header,  etc.  If we simply changed requiresCredentials to false, it would attempt a standard wget / curl / http request, and the result of that (even to the JDF url) is that it simply fetches an html page, which doesn't work. 

This means the current stacks.yaml label of "requiresCredentials" would be more accurately named something like "requiresWorkflow", but we can't change this because it'd break previous versions of JBT / JBDS.  Leaving it, however, would mean that the label says requiresCredentials=true even when an alpha release for example doesn't require credentials. 

I'm not sure how much of an issue this is, since at the moment the stacks.yaml file doesn't list any alpha releases at all. And, from what I can tell, beta releases all require credentials. 

So this only really becomes an issue if somehow an alpha release makes it into stacks.yaml, and even then it's only an issue if someone objects to the "requiresCredentials=true" flag. We may be forced to simply keep the requiresCredentials=true for alpha releases even though it's not technically true. 

> EAP alpha releases not require credentials; verify downloadRuntimes works
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-18709
>                 URL: https://issues.jboss.org/browse/JBIDE-18709
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: runtime-detection, server
>    Affects Versions: 4.2.0.Final, 4.2.1.Final, 4.3.0.Alpha1
>            Reporter: Rob Stryker
>
> A new requirement by the EAP team is asking for anonymous downloads of alpha releases. If such url's made it into stacks.yaml it *could* break our recent release. 
> We'll need to verify that if such a new url made it into stacks, it wouldn't break our download runtimes at all.  



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)