[jbosstools-issues] [JBoss JIRA] (JBIDE-18963) when whatsnew index generation is run on files that refer components that does not exist an error message containing what component is at fault should be printed

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038690#comment-13038690 ] 

Max Rydahl Andersen commented on JBIDE-18963:
---------------------------------------------

It is a problem *when* you have invalid components.

Try use a component name in whatsnew headers that does not exist in components.yml and you will get that hard to grasp error above.




> when whatsnew index generation is run on files that refer components that does not exist an error message containing what component is at fault should be printed
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-18963
>                 URL: https://issues.jboss.org/browse/JBIDE-18963
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: website
>    Affects Versions: 4.2.3.Beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.3.0.Alpha1
>
>
> today when having invalid components you get something like: 
> {code}
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:65:in `block (4 levels) in singletonclass'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:64:in `each'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:64:in `block (3 levels) in singletonclass'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:29:in `each'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:29:in `block (2 levels) in singletonclass'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:27:in `each'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:27:in `block in singletonclass'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:65533:in `instance_eval'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:65533:in `singletonclass'
> /Users/max/code/jbosstools/jbosstools-website/documentation/whatsnew/index.html.haml:65531:in `__tilt_70190394039780'
> {code}
> as found in https://github.com/jbosstools/jbosstools-website/pull/311/files
> the logic is all embedded in haml leaving no room for proper error handling.
> should do some basic asserts in the pipeline for that ids actually exists in components.yml or at least just use component id as fall back name.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)