[jbosstools-issues] [JBoss JIRA] (JBIDE-19194) FeedHenry requires minimal-json, but it was removed from TP

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039105#comment-13039105 ] 

Nick Boldt commented on JBIDE-19194:
------------------------------------

Back story:

{quote}
(2015-02-09 16:37:47) gercan: nickboldt: https://github.com/ralfstx/minimal-json seems to be missing from the latest TP
(2015-02-09 16:38:06) nickboldt: aw, crap.
(2015-02-09 16:38:40) gercan: nickboldt: feedhenry uses it 
(2015-02-09 16:39:09) nickboldt: ok - didn't know it was used for anything but Tern

(2015-02-09 16:42:04) nickboldt: gercan: you need this for 4.2.3 and 4.3.0, right?
(2015-02-09 16:42:59) gercan: nickboldt: yes, but 4.2.x seems to have it somehow
(2015-02-09 16:44:11) nickboldt: tp prolly hasn't finished rebuilding, or you're using the older tp
(2015-02-09 16:44:28) nickboldt: only removed it in the 4.42.x TP; still in the 4.40 and 4.41 versions
(2015-02-09 16:44:50) gercan: nickboldt: I had 4.41

(2015-02-09 16:47:01) nickboldt: gercan: can you just include it in your root pom? https://github.com/ralfstx/minimal-json#include
(2015-02-09 16:48:07) gercan: nickboldt: I could... you don't want it on TP?
(2015-02-09 16:48:18) nickboldt: *shrug*
(2015-02-09 16:48:30) nickboldt: well, I'm trying to find a stable update site 
(2015-02-09 16:48:57) nickboldt: and the version we had in Tern was older than the version on https://github.com/ralfstx/minimal-json#include (0.9.1 vs. 0.9.2)
16:55
(2015-02-09 16:55:25) nickboldt: gercan: benefit to being in the TP is it's avail at install time for all projects (including Aerogear)
(2015-02-09 16:55:54) nickboldt: but we could also include it in the Aerogear update site, and aggregate it into JBT like we do for Tern (it's actually already there)

(2015-02-09 16:57:40) gercan: nickboldt: why is this not in eclipse orbit?
(2015-02-09 17:02:21) nickboldt: gercan: I don't know. Why isn't it?
(2015-02-09 17:02:40) gercan: nickboldt: I thought Eclipse RAP is using it
(2015-02-09 17:02:54) nickboldt: yes. doesn't mean it's in orbit{quote}


> FeedHenry requires minimal-json, but it was removed from TP
> -----------------------------------------------------------
>
>                 Key: JBIDE-19194
>                 URL: https://issues.jboss.org/browse/JBIDE-19194
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: target-platform
>    Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.2.3.Beta1, 4.3.0.Alpha1
>
>
> When moving Tern from the 4.42.x and 4.50.x target platforms into JST, we also moved minimal-json assuming nothing else required it.
> But turns out that Feedhenry (Aerogear) also needs minimal-json.
> So... we need to add that plugin back into the TPs, and make sure that the version we include works with both Aerogear/FeedHenry (0.9.2, same code base in both 4.2.3 and 4.3.0, currently) and JST/Tern (0.9.1 in JBT 4.2, 0.9.2 in JBT 4.3).
> [~maxandersen] [~gercan] [~dgolovin] [~akazakov]
> In JBT 4.2.0-2 we include Tern 0.6 and minimal-json 0.9.1.
> In JBT 4.2.3 we include Tern 0.7 and minimal-json 0.9.1.
> In JBT 4.3.0 we _currently_ include Tern 0.8 and minimal-json 0.9.2.
> Which version should we include in the target platforms for JBT 4.2.3 (4.42.0.Beta1) and JBT 4.3.0 (4.50.0.Alpha1) ?



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)