[jbosstools-issues] [JBoss JIRA] (JBIDE-7379) Importing / Exporting of AS servers ignore command line args, filesets, xpaths, and even runtimes

[Paul Richardson (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040098#comment-13040098 ] 

Paul Richardson commented on JBIDE-7379:
----------------------------------------

Hey [~rob.stryker]

Firstly my apologies to now answering sooner and that you have done so much work on this. I also created a topic branch with a version of import/export but was in [Teiid's repository||https://github.com/phantomjinx/teiid-designer/commits/TEIIDDES-1119] rather than jboss'. Anyway, they look pretty similar although your API has made some assumptions which I tried to avoid, ie.
* The exported storage unit would be a zip. I used a non-specific IStorageSource interface then implement a DirectorySource initially for testing purposes;
* The config/artefacts being exported would only be parts of an IServer;
* Export constituents (IStorageUnit) would declare themselves part of categories, which become sub-directories in the directory storage source or in a zip/jar storage source.

The upshot of this is that with your API only expecting to export server configuration, only the Teiid server configuration would be exportable. However, Teiid also has file artefacts, stored in other parts of the workspace which need a separate storage unit (not implemented yet).

I was intending to implement this as extensions of the Import.../Export... actions in Eclipse. You may have done the same, just cannot see it at the moment, what do you think?

Not sure where next with this. TEIIDDES-1119 work has stood still since June due to my switching to working on the Teiid Komodo engine. I think I am due to return to it when the engine has been stood up but that probably will not be for about 6 months or so. Thus, don't know whether to ignore my branch, merge in some of its ideas ... Anyway, let me know your thoughts/plans.

Apologies for not replying sooner.

Paul


> Importing / Exporting of AS servers ignore command line args, filesets, xpaths, and even runtimes
> -------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-7379
>                 URL: https://issues.jboss.org/browse/JBIDE-7379
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.2.0.Beta1
>            Reporter: Rob Stryker
>            Assignee: Paul Richardson
>             Fix For: 4.3.x
>
>
> Exporting of servers is incomplete. It does not export any saved filesets, xpaths, or custom launch configuration args. 
> Importing of servers is also incomplete, not importing any of these elements. Also, while the servers themselves are imported, sometimes their runtimes are not created at all, and you get a server with no runtime. This has been very hard to track down, but no runtimeAdded event is ever fired, and in our code it looks as if they're not even created or looked for. 
> This needs to be re-visited and tested extensively. I expect I will move import / export functionality into the AS plugin for now since hte o.j.t.runtime plugin already depends on AS. This will allow me to use classes already in the AS test suite for filesets and xpaths properly. I will keep the handler in the runtimes plugin but merely have it delegate to the functionality stored in the as plugin. 
> It currently seems to be saving only servers and not the runtimes. 



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)