[jbosstools-issues] [JBoss JIRA] (JBIDE-14782) Add ShrinkWrap Archive file location validation

[Lucia Jelinkova (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041278#comment-13041278 ] 

Lucia Jelinkova commented on JBIDE-14782:
-----------------------------------------

To sum up what has been done:

- there are no validations for "Not supported" descriptors - I am OK with that since it should make no harm
- JAR - no validations - that should be OK too
- EAR - no validation for application.xml
- WAR
-- validation for beans.xml and web.xml going to WEB-INF
--- addAsManifestResource - OK
--- addAsWebResource - NOK
-- validation for persistence.xml and ejb-jar.xml
--- addAsWebInfResource - OK
--- addAsWebResource - NOK

> Add ShrinkWrap Archive file location validation
> -----------------------------------------------
>
>                 Key: JBIDE-14782
>                 URL: https://issues.jboss.org/browse/JBIDE-14782
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: testing-tools
>            Reporter: Aslak Knutsen
>            Assignee: Snjezana Peco
>              Labels: new_and_noteworthy
>             Fix For: 4.3.0.Alpha1
>
>
> *Given*
> A Deployment method
> *When*
> {code}
> war.addAsManifestResource(X, "beans.xml")
> ear.addAsManifestResource(X, "beans.xml")
> war.addAsManifestResource(X, "persistence.xml")
> {code}
> *Then*
> Warn that known EE descriptor files are in the wrong location
> Some mapping on top of my head:
> WebArchive
> {code}
> web.xml          -> /WEB-INF/
> web-fragment.xml -> Not supported ? 
> beans.xml        -> /WEB-INF/
> persistence.xml  -> /WEB-INF/classes/META-INF/
> ejb-jar.xml      -> /WEB-INF/classes/META-INF/
> {code}
> JavaArchive
> {code}
> web.xml          -> Not supported
> web-fragment.xml -> /META-INF/
> beans.xml        -> /META-INF/
> persistence.xml  -> /META-INF/
> ejb-jar.xml      -> /META-INF/
> {code}
> EnterpriseArchive
> {code}
> beans.xml        -> Not supported
> persistence.xml  -> Not supported
> ejb-jar.xml      -> Not supported
> application.xml  -> /META-INF/
> {code}
> One common mistake is using addAsManifestResource on WebArchives. A quickfix / suggestion would be to use addAsWebInfResource for the files located in /WEB-INF/



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)