[jbosstools-issues] [JBoss JIRA] (JBIDE-19184) Threadlock when JS autocomplete turned on

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041634#comment-13041634 ] 

Victor Rubezhny commented on JBIDE-19184:
-----------------------------------------

Probably, [~azerr] has meant "it's very hard to move this feature to 0.7.x" (not 0.8.x)... Yes, I'm not able to merge these changes into 0.7.x branch - there are too many changes and refactorings there since 0.7.0, so...

If we can create a branch 0.8.1 based on Tern.java 0.8.0, and cherry-pick the following commits into that branch:

* cad62ff - (HEAD, ternAsyncTernServerRequests-0.8.x) Fix https://github.com/angelozerr/tern.java/issues/251 (8 seconds ago) <vrubezhny>
* 7af4dde - Fix https://github.com/angelozerr/tern.java/issues/247 (8 seconds ago) <angelozerr>
* 2ae4096 - Fix for issue #240 and issue #237 (40 minutes ago) <Piotr Tomiak>
* b97cfee - Fix https://github.com/angelozerr/tern.java/issues/239 (40 minutes ago) <angelozerr>
* 84e5b2f - Issue #171: Allow for cancellation of upload job. (40 minutes ago) <Piotr Tomiak>
* c889f1b - Issue #171: Preference for disabling asynchronous requests. (40 minutes ago) <Piotr Tomiak>
* 49fccdb - Asynchronous requests to Tern Server (Issue #171) (40 minutes ago) <Piotr Tomiak>

then we can have that asynchronous Tern Server requests in Content assist instead of blocked Eclipse in Tern.java 0.8.x stream. 

This looks like a working way for me (At least I cannot reproduce the 'Deadlock' issue using such branch).  And IMHO we can use this approach in JBT 4.2.3. 

[~azerr] may use my branch which is based on Tern.java 0.8.0 release due to cherry-pick the commits listed above into 0.8.x-branch (if he'll agreed to do his work for us): https://github.com/vrubezhny/tern.java/tree/ternAsyncTernServerRequests-0.8.x
(I cannot do a PR, because there is no a branch created and customized for 0.8.x stream yet).

In case it's a suitable solution then we'll have to ask [~azerr] and Pascal Leclercq to create a 0.8.x stream for Tern.java and AngularJS-Eclipse (I didn't dig into the changes required to AngulatJS-eclipse regarding this issue yet, but I hope there are not too many changes there) and release the versions 0.8.1 of Tern/Angular for us.

Other alternatives are:

* Use 0.7.1 as is, but the 'Deadlock' issue is a real show stopper. :(
* Switch to 0.9.0, but it's not released, as such, it isn't tested well and probably will be changed after the release of JBT 4.2.3. IMHO, it's not a great option for JBT 4.2.3.

There is not too much time left before the release of JBT 4.2.3, so we have to decade what to do ASAP.

> Threadlock when JS autocomplete turned on
> -----------------------------------------
>
>                 Key: JBIDE-19184
>                 URL: https://issues.jboss.org/browse/JBIDE-19184
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml/html source editing, upstream
>    Affects Versions: 4.2.2.Final
>         Environment: JBDS 8.0.2
>            Reporter: Mustafa Musaji
>            Assignee: Victor Rubezhny
>            Priority: Critical
>             Fix For: 4.2.3.Beta1, 4.3.0.Alpha2
>
>         Attachments: threaddump_jdk1.7.0_71_1422011702000.txt
>
>
> Seeing  a thread lock when using large JS projects when trying to autocomplete. Please refer to attached thread dump.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)