[jbosstools-issues] [JBoss JIRA] (JBIDE-18866) allow URL in the form "from-code=git at github.com" for custom app source code and downloadable cartridges

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043201#comment-13043201 ] 

Andre Dietisheim commented on JBIDE-18866:
------------------------------------------

Unfortunately I can reproduce this. This is caused by the Eclipse Tooling. 
For documentation purpose I see the following cause:

{code:CodeAnythingCartridge}
@Override
	public URL getUrl() {
		try {
			return new URL(urlString);
		} catch (MalformedURLException e) {
			return null;
		}
	}
{code}
urlString has the correct value ("git at github.com:openshift-cartridges/openshift-wildfly-cartridge.git/") but it may not be turned into a java.net.URL. The above snippet thus returns *null* and causes us to request to send bad parameters.

> allow URL in the form "from-code=git at github.com" for custom app source code and downloadable cartridges
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-18866
>                 URL: https://issues.jboss.org/browse/JBIDE-18866
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.2.0.Final
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>              Labels: new_and_noteworthy
>             Fix For: 4.3.0.Alpha2
>
>
> We should be able to use urls that refer to github repositories when using custom application source code and downloadable cartridges



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)