[jbosstools-issues] [JBoss JIRA] (JBIDE-13835) Improve publish script (split? Move to maven?)

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043231#comment-13043231 ] 

Max Rydahl Andersen commented on JBIDE-13835:
---------------------------------------------

"So for the use case of "I want to rebuild JBDS from source" you suggest people take a few hundred source plugins, unpack them all, and build them one by one?
What we have today is a zip containing 17 subfolders (one per github project) which can be built in series without any futzing other than unpacking the zip. "

No, I suggest each component site build zips the source they are being built from and produce a source artifact that then gets aggregated.

   " why don't our maven builds produce -source artifacts?

There has never been a request for that. There has ONLY ever been a request for a JBT and JBDS source zip."

There has never been a request for fetching source from github - that was your choice on implementing the requirement. I'm here suggesting another one that removes any dependency on having to fetch from external server and from possible different content than what was used.

"Therefore it's more expedient to get the sources when we need them rather than producing and aggregating source zips into a larger JBT and JBDS zip. Do we have a community need for source zips? Surely for the community people can just go to github directly and fetch from the appropriate tag, branch, or SHA?"

I do not understand why you want request from community to make this relevant to do. 
The suggestion here I make I believe removes need on fetching sources again and from potentially different location - it makes the testing and reproducibility of our build pipleine much less dependent on future/external changes.

about publish.sh I would probably make publish.sh call rsync.sh and then cleanup.sh to have these two steps independently more easily.

And having md5 etc. generation done by the builds them self instead of done at publish step unless there is something I'm missing about why that must be at the publish step.






> Improve publish script (split? Move to maven?)
> ----------------------------------------------
>
>                 Key: JBIDE-13835
>                 URL: https://issues.jboss.org/browse/JBIDE-13835
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>            Reporter: Mickael Istria
>             Fix For: 4.3.x
>
>
> Publish script deals with a lot of different and not-always-related things. It makes it difficult to maintain it. We should think about some improvements such as
> * different conventions from different stream
> * components vs aggregate
> * devstudio vs jbosstools.
> Or,
> * Make publishing part of a "mvn deploy" step.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)