[jbosstools-issues] [JBoss JIRA] (JBDS-3303) [unit test] versionwatch should not fail silently when the report is empty

Nick Boldt (JIRA) issues at jboss.org
Wed Jan 7 18:18:29 EST 2015


    [ https://issues.jboss.org/browse/JBDS-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030694#comment-13030694 ] 

Nick Boldt edited comment on JBDS-3303 at 1/7/15 6:18 PM:
----------------------------------------------------------

This PR does a few things:

a) adds support for filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x)
b) provides a shell script wrapper for the versionwatch tool, to replace the mix of maven and shell (which was why we were getting empty reports - maven vars wer being passed in incorrectly)
c) shell script also now includes a couple unit tests on the results. 

Unit tests currently include:

{code}
1. `egrep -l "<td>|<tr>"` -- empty report
1. `egrep -l "ERROR` -- report with errors
{code}

https://github.com/jbdevstudio/jbdevstudio-qa/pull/30



was (Author: nickboldt):
This PR does a few things:

a) adds support for filtering which versions to compare (eg., to exclude diffing a JBDS 8 build against a future JBDS 9 build when we just want versionwatch for JBDS 8.0.x)
b) provides a shell script wrapper for the versionwatch tool, to replace the mix of maven and shell (which was why we were getting empty reports - maven vars wer being passed in incorrectly)
c) shell script also now includes a couple unit tests on the results. 

Unit tests currently include:

{code}
1. `egrep -l "<td>|<tr>"` -- empty report
1. 1egrep -l "ERROR` -- report with errors
{code}

https://github.com/jbdevstudio/jbdevstudio-qa/pull/30

[~psrna], please review.

> [unit test] versionwatch should not fail silently when the report is empty
> --------------------------------------------------------------------------
>
>                 Key: JBDS-3303
>                 URL: https://issues.jboss.org/browse/JBDS-3303
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 8.0.1.GA
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>
> versionwatch should not fail silently when the report is empty, such as:
> {code}
> JBDS Version Watch
> Feature list for filter = .*(hibernate\|jboss\|xulrunner).*
> Plugin list for filter = .*(hibernate\|jboss\|xulrunner).*
> Generated by VersionWatch 0.3.0 in 0 min, 4 sec at 2014-12-14 20:19:34.853.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)


More information about the jbosstools-issues mailing list