[jbosstools-issues] [JBoss JIRA] (JBIDE-16108) Preferences: Timeout preferences should not set system properties but operation specific timeout

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031303#comment-13031303 ] 

Andre Dietisheim commented on JBIDE-16108:
------------------------------------------

setting fixVersion to LATER since the main focus now is to create tooling for OpenShift v3.

> Preferences: Timeout preferences should not set system properties but operation specific timeout
> ------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-16108
>                 URL: https://issues.jboss.org/browse/JBIDE-16108
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.1.CR1
>            Reporter: Andre Dietisheim
>              Labels: preferences
>             Fix For: LATER
>
>
> In JBIDE-16046 we introduced an Eclipse Preferences to set the openshift-java-clilent timeouts. These preferences currently set the lib specific system property which is not good. Consider the following usecase:
> 1) User launches Eclipse and has system property set to 10000 (-D): Eclipse Preferences display 10000
> 2) User sets preference to 1234
> 3) restarts Ecllipse: Preferences display 1234 
> 3) happens because we load the value from eclipse preferences and override the system property
> We should keep both separate: System property and Eclipse preferences:
> We use operation specific timeouts in all Eclipse code and make the Eclipse preferences provide some value for this. Leaving the system property alone.
> We should also:
> * add a checkbox for "[ ] use default"
> * change openshift-java-client to differentiate "no value" (<0) and value set (>=0)
> * remove current hard-coded safe default in openshift-java-client, replace it by system-property we already have).



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)