[jbosstools-issues] [JBoss JIRA] (JBIDE-15332) why are skipRequirements controlling download of normal maven dependencies ?
Nick Boldt (JIRA)
issues at jboss.org
Fri Jan 23 14:46:49 EST 2015
[ https://issues.jboss.org/browse/JBIDE-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034715#comment-13034715 ]
Nick Boldt commented on JBIDE-15332:
------------------------------------
Seems reasonable but we also have another property for controlling download of runtimes in Server (as set in parent pom): <skipITests>false</skipITests>
(Then used in jbosstools-server/as/itests/pom.xml )
What do we do with that property? Does skipTestRequirements replace skipITests?
cc: [~rob.stryker]
> why are skipRequirements controlling download of normal maven dependencies ?
> ----------------------------------------------------------------------------
>
> Key: JBIDE-15332
> URL: https://issues.jboss.org/browse/JBIDE-15332
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Beta1
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Labels: f2f2014
> Fix For: 4.3.0.Alpha1
>
>
> I stumbled on [~dgolovin]'s patch for livreload at https://github.com/jbosstools/jbosstools-livereload/pull/54/files
> This is not the first time i've seen skip having to be enabled for plain normal mvn dependencies.
> skipRequirements are supposed to only cover big downloads (like EAP, jboss etc.) - things done via non-maven download mechanism.
> Why is this applied to mvn dependency downloads ?
> The culprit for needing this line is at:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L397
> and a bugzilla (*not* jira?!) is referenced as the reason for this back in 2012: https://github.com/jbosstools/jbosstools-build/commit/2e18baaf88e0cd73b3b99885658e00789e8fd198
> I understand why the explicit google download plugin (why is there two versions used btw?) but why is skipTests controlling normal mvn dependency download ? Which requirements are using this for download ?
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
More information about the jbosstools-issues
mailing list