[jbosstools-issues] [JBoss JIRA] (JBIDE-20171) buildinfo.json reader fails if upstream MANIFEST.MF contains no SHA

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085822#comment-13085822 ] 

Nick Boldt edited comment on JBIDE-20171 at 7/2/15 9:38 AM:
------------------------------------------------------------

Doesn't really matter if we rebuild it w/ new qualifiers or not; it'll still be published to the same folder and built from the same SHA at github. So the only difference between the version from 2012-11-26 @ 18:50:16 (build # 155) and a new rebuild will be the inclusion of Eclipse-SourceReferences in the MANIFEST.MF files. I agree w/ Max that we should use a new qualifier in the build.

{quote}By "expected & good" you mean "expected and issue should be fixed" or "expected, but it is okey to have this SHA missing" ? {quote}

I mean "it's expected that a missing SHA causes the comparison between 'SHA in buildinfo.json' and 'SHA in MANIFEST.MF' to fail the build. 

HOWEVER... the current build has hardcoded qualifiers for the plugins, but fully-generated ones for the features:

* http://download.jboss.org/jbosstools/updates/requirements/xulrunner-1.9.2/plugins/
* http://download.jboss.org/jbosstools/updates/requirements/xulrunner-1.9.2/features/

If you think it's acceptable that the JBT aggregate build should allow a SHA check to PASS if there's no SHA in the manifest, then I can change the code to allow that. But I'd rather that the build fail if no Eclipse-SourceReference can be found.

See also https://github.com/jbosstools/jbosstools-maven-plugins/commit/916f4521ba6cd546def43ad11ff02d9c5468c156#diff-0e46efec8a6217a14cae80c69dfbd9ebR336



was (Author: nickboldt):
Doesn't really matter if we rebuild it w/ new qualifiers or not; it'll still be published to the same folder and built from the same SHA at github. So the only difference between the version from 2012-11-26 @ 18:50:16 (build # 155) and a new rebuild will be the inclusion of Eclipse-SourceReferences in the MANIFEST.MF files. I agree w/ Max that we should use a new qualifier in the build.

{quote}By "expected & good" you mean "expected and issue should be fixed" or "expected, but it is okey to have this SHA missing" ? {quote}

I mean "it's expected that a missing SHA causes the comparison between 'SHA in buildinfo.json' and 'SHA in MANIFEST.MF' to fail the build. 

See also https://github.com/jbosstools/jbosstools-maven-plugins/commit/916f4521ba6cd546def43ad11ff02d9c5468c156#diff-0e46efec8a6217a14cae80c69dfbd9ebR336

If you think it's acceptable that the JBT aggregate build should allow a SHA check to PASS if there's no SHA in the manifest, then I can change the code to allow that. But I'd rather that the build fail if no Eclipse-SourceReference can be found.

> buildinfo.json reader fails if upstream MANIFEST.MF contains no SHA
> -------------------------------------------------------------------
>
>                 Key: JBIDE-20171
>                 URL: https://issues.jboss.org/browse/JBIDE-20171
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 4.3.0.Beta2
>            Reporter: Nick Boldt
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.3.0.Beta2
>
>
> Since the addition of a check that verifies exactly this condition:
> https://github.com/jbosstools/jbosstools-maven-plugins/commit/916f4521ba6cd546def43ad11ff02d9c5468c156
> I've now got a situation where it's OK to have no SHA in the MANIFEST.MF, but a SHA in buildinfo.json.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.site_master/10216/console}
> [ERROR] Failed to execute goal org.jboss.tools.tycho-plugins:repository-utils:0.22.1-SNAPSHOT:fetch-sources-from-manifests (fetch-sources) on project org.jboss.tools.site.core: Problem occurred checking upstream buildinfo.json files!
> [ERROR] /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_master/sources/aggregate/site/target/buildinfo/buildinfo_jbosstools-xulrunner.json
> [ERROR] contains 2edce933f7d64efbb4d7a5b16be8dadae8de766e, but upstream project's MANIFEST.MF has Eclipse-SourceReferences
> [ERROR] commitId .
> [ERROR] If you have locally built projects which are aggregated here,
> [ERROR] ensure they are built from the latest SHA from HEAD, not a local topic branch.
> [ERROR] Or, use -DskipCheckSHAs=true to bypass this check.
> [ERROR] -> [Help 1]{code}
> This happened after I put a buildinfo.json file here:
> http://download.jboss.org/jbosstools/updates/requirements/xulrunner-1.9.2/buildinfo.json
> I've since moved the file here to temporarily work around the build failure:
> http://download.jboss.org/jbosstools/updates/requirements/xulrunner-1.9.2/buildinfo_2012-11-26_18-50-16-B155.json



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)