[jbosstools-issues] [JBoss JIRA] (JBIDE-20171) buildinfo.json reader fails if upstream MANIFEST.MF contains no SHA

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087536#comment-13087536 ] 

Nick Boldt edited comment on JBIDE-20171 at 7/7/15 2:48 PM:
------------------------------------------------------------

Now in the build log we get these  warnings:

{code}
[WARNING] Cannot fetch jbosstools-xulrunner sources: no Eclipse-SourceReferences in org.mozilla.xpcom_1.9.2.16.jar MANIFEST.MF
[WARNING] 
/mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_master/sources/aggregate/site/target/buildinfo/buildinfo_jbosstools-xulrunner.json
contains 2edce933f7d64efbb4d7a5b16be8dadae8de766e, but upstream jbosstools-xulrunner project's MANIFEST.MF has no Eclipse-SourceReferences commitId.
Using sources from 2edce933f7d64efbb4d7a5b16be8dadae8de766e.
[INFO] Downloaded:  jbosstools-xulrunner_2edce933f7d64efbb4d7a5b16be8dadae8de766e_sources.zip (46.5 M)
{code}

And the JBT sources zip is larger as it includes the Xulrunner sources too.

http://download.jboss.org/jbosstools/mars/staging/builds/jbosstools-4.3.0.Beta1c-build-core/2015-06-18_21-49-21-B59/all/jbosstools-4.3.0.Beta1-src.zip *285M*
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.site_master/latest/all/jbosstools-4.3.0.Beta2-src.zip *332M*


was (Author: nickboldt):
Now in the build log we get these harmless warning:

{code}
[WARNING] Cannot fetch jbosstools-xulrunner sources: no Eclipse-SourceReferences in org.mozilla.xpcom_1.9.2.16.jar MANIFEST.MF
[WARNING] 
/mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_master/sources/aggregate/site/target/buildinfo/buildinfo_jbosstools-xulrunner.json
contains 2edce933f7d64efbb4d7a5b16be8dadae8de766e, but upstream jbosstools-xulrunner project's MANIFEST.MF has no Eclipse-SourceReferences commitId.
Using sources from 2edce933f7d64efbb4d7a5b16be8dadae8de766e.
[INFO] Downloaded:  jbosstools-xulrunner_2edce933f7d64efbb4d7a5b16be8dadae8de766e_sources.zip (46.5 M)
{code}

And the JBT sources zip is larger as it includes the Xulrunner sources too.

http://download.jboss.org/jbosstools/mars/staging/builds/jbosstools-4.3.0.Beta1c-build-core/2015-06-18_21-49-21-B59/all/jbosstools-4.3.0.Beta1-src.zip *285M*
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.site_master/latest/all/jbosstools-4.3.0.Beta2-src.zip *332M*

> buildinfo.json reader fails if upstream MANIFEST.MF contains no SHA
> -------------------------------------------------------------------
>
>                 Key: JBIDE-20171
>                 URL: https://issues.jboss.org/browse/JBIDE-20171
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 4.3.0.Beta2
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta2
>
>
> Since the addition of a check that verifies exactly this condition:
> https://github.com/jbosstools/jbosstools-maven-plugins/commit/916f4521ba6cd546def43ad11ff02d9c5468c156
> I've now got a situation where it's OK to have no SHA in the MANIFEST.MF, but a SHA in buildinfo.json.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.site_master/10216/console}
> [ERROR] Failed to execute goal org.jboss.tools.tycho-plugins:repository-utils:0.22.1-SNAPSHOT:fetch-sources-from-manifests (fetch-sources) on project org.jboss.tools.site.core: Problem occurred checking upstream buildinfo.json files!
> [ERROR] /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_master/sources/aggregate/site/target/buildinfo/buildinfo_jbosstools-xulrunner.json
> [ERROR] contains 2edce933f7d64efbb4d7a5b16be8dadae8de766e, but upstream project's MANIFEST.MF has Eclipse-SourceReferences
> [ERROR] commitId .
> [ERROR] If you have locally built projects which are aggregated here,
> [ERROR] ensure they are built from the latest SHA from HEAD, not a local topic branch.
> [ERROR] Or, use -DskipCheckSHAs=true to bypass this check.
> [ERROR] -> [Help 1]{code}
> This happened after I put a buildinfo.json file here:
> http://download.jboss.org/jbosstools/updates/requirements/xulrunner-1.9.2/buildinfo.json
> I've since moved the file here to temporarily work around the build failure:
> http://download.jboss.org/jbosstools/updates/requirements/xulrunner-1.9.2/buildinfo_2012-11-26_18-50-16-B155.json



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)