[jbosstools-issues] [JBoss JIRA] (JBIDE-19814) sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product)

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089457#comment-13089457 ] 

Nick Boldt edited comment on JBIDE-19814 at 7/14/15 3:50 PM:
-------------------------------------------------------------

PRs applied in master to make JBT and JBDS both use the same mojo for creating source zips. Also allows xulrunner to specify a buildinfo.json file instead of a plugin from which to search MANIFEST.MF for a SHA.

https://github.com/jbosstools/jbosstools-maven-plugins/pull/48
https://github.com/jbosstools/jbosstools-build-sites/pull/198
https://github.com/jbdevstudio/jbdevstudio-product/pull/321 and https://github.com/jbdevstudio/jbdevstudio-product/pull/322


was (Author: nickboldt):
PRs applied in master to make JBT and JBDS both use the same mojo for creating source zips. Also allows xulrunner to specify a buildinfo.json file instead of a plugin from which to search MANIFEST.MF for a SHA.

https://github.com/jbosstools/jbosstools-maven-plugins/pull/48
https://github.com/jbosstools/jbosstools-build-sites/pull/198
https://github.com/jbdevstudio/jbdevstudio-product/pull/321

> sources zip should include local sources too (jbosstools-build-sites or jbdevstudio-product)
> --------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19814
>                 URL: https://issues.jboss.org/browse/JBIDE-19814
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta2, 4.3.0.CR1
>
>
> If we change the way the jbosstools-src.zip is produced, such that in addition to upstream projects it ALSO includes the contents of jbosstools-build-sites too, then we can reuse that mojo for the jbdevstudio-product src.zip too, as it will ALSO include the 17 upstream JBT zips (from Github) and also the local JBDS sources. 
> This would mean a large chunk of ant code in jbdevstudio-product/sources/build.xml (if not all of it) could go away. Hooray for 1 solution spanning both projects and product! :D
> Max also suggested that we use a clean copy of the sources just in case the build process makes them dirty:
> {code}
>  git clone --depth=1 . clean-sources-dir && rm -rf clean-sources-dir/.git{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)