[jbosstools-issues] [JBoss JIRA] (JBDS-3487) p2 director install tests should support install of JBDS from installer, not just BYOE on Eclipse

[Nick Boldt (JIRA)]

     [ https://issues.jboss.org/browse/JBDS-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Boldt updated JBDS-3487:
-----------------------------
    Description: 
Max, in JBDS-3485, said:

{quote}
"I believe the tests all use BYOE install onto JavaEE, not JBDS installer. " that seems very unfortunate and weird since install grinder was written using JBDS to start with.

Can you please make sure we got tests that covers this so we can catch missing pieces like this faster in future ? Thanks.
{quote}


The p2 director install test uses the same getAndInstallEclipse.groovy [1] mentioned in JBDS-3486 to perform installation of JBT & JBDS discovery site content onto an Eclipse install.

[1] https://github.com/jbosstools/jbosstools-install-grinder/blob/master/scripts/src/main/groovy/getAndInstallEclipse.groovy

Then, it does this:

{code}
${WORKSPACE}/sources/util/installFromCentral.sh -ECLIPSE ${WORKSPACE}/eclipse -INSTALL_PLAN "${INSTALL_PLAN}"
{code}

So, it would not be difficult to call a JBDS installer headlessly, then use a different value for -ECLIPSE in the above invocation to install on top of JBDS instead of Eclipse.



  was:
Max, in JBDS-3485, said:

{quote}
"I believe the tests all use BYOE install onto JavaEE, not JBDS installer. " that seems very unfortunate and weird since install grinder was written using JBDS to start with.

Can you please make sure we got tests that covers this so we can catch missing pieces like this faster in future ? Thanks.
{quote}


https://github.com/jbosstools/jbosstools-install-grinder/tree/master/scripts/src/main/groovy shows two scripts. One fetches and installs Eclipse; the other performs an installation from an update site or discovery site's directory.xml file.

In neither case is there support for installing JBDS (instead of Eclipse) and performing installations upon that base.





> p2 director install tests should support install of JBDS from installer, not just BYOE on Eclipse
> -------------------------------------------------------------------------------------------------
>
>                 Key: JBDS-3487
>                 URL: https://issues.jboss.org/browse/JBDS-3487
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 9.0.0.Beta2
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>
> Max, in JBDS-3485, said:
> {quote}
> "I believe the tests all use BYOE install onto JavaEE, not JBDS installer. " that seems very unfortunate and weird since install grinder was written using JBDS to start with.
> Can you please make sure we got tests that covers this so we can catch missing pieces like this faster in future ? Thanks.
> {quote}
> The p2 director install test uses the same getAndInstallEclipse.groovy [1] mentioned in JBDS-3486 to perform installation of JBT & JBDS discovery site content onto an Eclipse install.
> [1] https://github.com/jbosstools/jbosstools-install-grinder/blob/master/scripts/src/main/groovy/getAndInstallEclipse.groovy
> Then, it does this:
> {code}
> ${WORKSPACE}/sources/util/installFromCentral.sh -ECLIPSE ${WORKSPACE}/eclipse -INSTALL_PLAN "${INSTALL_PLAN}"
> {code}
> So, it would not be difficult to call a JBDS installer headlessly, then use a different value for -ECLIPSE in the above invocation to install on top of JBDS instead of Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)