[jbosstools-issues] [JBoss JIRA] (JBIDE-19810) easymport is slow and wrong compared to basic import since it lets mvn overrule .project

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13077382#comment-13077382 ] 

Max Rydahl Andersen commented on JBIDE-19810:
---------------------------------------------

{quote}
The reason is that when you have a project imported, you get access to several pieces of data that can help in continuing the discovery (mainly, which folders to exclude from deep analysis). If you don't have the project imported, it's difficult to get access to this interesting hints and to make a good proposal.
{quote}

As said before I disagree with this. It is very easy to detect some coarse grained detections without actually importing projects. If it was not possible to detect without eclipse projects then you could not do easyimport at all.

Just scan for major project types (like eclipse, maven, gradle, intellij, netbeans, cdt, thym, wtp,java etc.) and have that as a first scan and then *after* user said "yes, this is okey" then you can start going deeper. But for example for  maven project it is just much saner to just let maven do the handling of children projects  - easy import should not try second guess here (at least not by default)

so in short - instead of doing everything upfront, do the detection in 2 phases instead of one big one that will have a lot of sideeffects.

{quote}
    mylyn does not work as maven import - should be imported strictly as eclipse projects.

Can you please refine "does not work" ?
{quote}

I have not looked deeper but it is not meant to be imported as a maven project, only built from command line for tycho.

> easymport is slow and wrong compared to basic import since it lets mvn overrule .project
> ----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19810
>                 URL: https://issues.jboss.org/browse/JBIDE-19810
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: easymport
>            Reporter: Max Rydahl Andersen
>            Priority: Critical
>             Fix For: 4.3.0.Beta2
>
>
> when using git://git.eclipse.org/gitroot/mylyn/org.eclipse.mylyn.docs.git it already has tons of projects with .project in it but also pom.xml. Resulting in slow and eventually wrong imported projects.
> This import is *really* slow with easyimport vs just using plain file import. 
> Shouldn't easyimport honor existing .project files over presence of a pom.xml (or anything else) ? 
> If not could we allow users to disable certain configurators for an import or even reorder priority so mvn wont win ?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)