[jbosstools-issues] [JBoss JIRA] (JBIDE-20025) new commits in master branch == portlet must be upversioned

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13077532#comment-13077532 ] 

Nick Boldt commented on JBIDE-20025:
------------------------------------

There is no reason to build portlet. Look at the commits. They are irrelevant. If there was a REAL commit (functional change other than bumping root pom's ref to parent pom or using Junit 4 instead of 3.8 JUST IN CASE we need to rebuild portlet some time in the future) then yes, we'd be building and aggregating it.

But since there's been NO *development* work in the master branch since the 4.2.x branch, *I've re-disabled the job*. We won't pick up "identical but with new version" bits simply because a test is failing to validate the version against the baseline. 

What SHOULD have happened is that NO changes were done in the master branch; then, the SHA would be the same as the last build from 4.2.x, and the test would pass.

> new commits in master branch == portlet must be upversioned
> -----------------------------------------------------------
>
>                 Key: JBIDE-20025
>                 URL: https://issues.jboss.org/browse/JBIDE-20025
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: portal-gatein
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Snjezana Peco
>             Fix For: 4.3.0.Beta2
>
>
> [~dgolovin] reports that whenever he builds Portlet from master branch, it fails because it's got the same plugin/feature versions as the previous baseline release, but there are new commits / SHAs since that baseline.
> So, portlet should be upversioned so that the version validation test won't fail.
> cc: [~mickael_istria] [~maxandersen] [~snjeza]
> (The reason this happened is that people committed changes to a branch of code which is no longer being developed. Since not being developed, no one upversioned the code along with those commits.)
> The alternative solution to this issue is that @dgolovin should simply stop building portlet locally. We don't build it in Jenkins for the same reason. :D



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)