[jbosstools-issues] [JBoss JIRA] (JBIDE-20025) new commits in master branch == portlet must be upversioned

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13077672#comment-13077672 ] 

Nick Boldt commented on JBIDE-20025:
------------------------------------

[~snjeza] PR https://github.com/jbosstools/jbosstools-portlet/pull/34 is invalid. What if there's maintenance needed in the 4.2.x branch? How would you upversion those plugins, if they're all 1.6.0 in 4.2.x branch, and master now contains 1.6.1?

Master should be at 1.6.100, per https://wiki.eclipse.org/Version_Numbering#Overall_example (Third dev stream)

--

As to monitoring the project for such time as when real commits appear, seems like QE is better at that than I am. See JBIDE-20041. Why bother building it (and wasting Jenkins resources that other teams could use) if there are NO NEW COMMITS to build? Remember, we have a buildflow that periodically rebuilds everything (just to verify cross-compilation still works when upstream APIs are updated or TPs change). But yeah, we could turn the job on, and then NOT use it in the parent pom / composite sites. Would you prefer that? Wouldn't help w/ forgetting to include new stuff (as in JBIDE-20041) but would have caught [~dgolovin] 's problem w/ baseline version bump validation.

> new commits in master branch == portlet must be upversioned
> -----------------------------------------------------------
>
>                 Key: JBIDE-20025
>                 URL: https://issues.jboss.org/browse/JBIDE-20025
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: portal-gatein
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Snjezana Peco
>             Fix For: 4.3.0.Beta2
>
>
> [~dgolovin] reports that whenever he builds Portlet from master branch, it fails because it's got the same plugin/feature versions as the previous baseline release, but there are new commits / SHAs since that baseline.
> So, portlet should be upversioned so that the version validation test won't fail.
> cc: [~mickael_istria] [~maxandersen] [~snjeza]
> (The reason this happened is that people committed changes to a branch of code which is no longer being developed. Since not being developed, no one upversioned the code along with those commits.)
> The alternative solution to this issue is that @dgolovin should simply stop building portlet locally. We don't build it in Jenkins for the same reason. :D



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)