[jbosstools-issues] [JBoss JIRA] (JBIDE-20065) hibernate util.invoke* silently swallows NoSuchMethod

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078547#comment-13078547 ] 

Max Rydahl Andersen commented on JBIDE-20065:
---------------------------------------------

[~koen.aers] look at PR associated with JBIDE-20042.

We need tests for these kind of basic issues AND we need to not swallow the exceptions since alot of issues are just hidden.

Having a simple test that calls every method on each of the service classes would have caught that some code was broken. i.e. for every set make sure the get returns the expected value. If not - boom there must be an error.

This could be expressed in a test that works for every version of supported hibernate since with your refactoring the external api is 99% the same.

That would cover the core.

And UI would be much more likely to survive.


> hibernate util.invoke* silently swallows NoSuchMethod
> -----------------------------------------------------
>
>                 Key: JBIDE-20065
>                 URL: https://issues.jboss.org/browse/JBIDE-20065
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: hibernate
>            Reporter: Max Rydahl Andersen
>            Priority: Critical
>             Fix For: 4.3.0.Beta2
>
>
> as seen in JBIDE-20042 errors are swalloed (just logged) meaning many methods to hibernate just returns null resulting in broken logic.
> Example: https://github.com/jbosstools/jbosstools-hibernate/blob/master/plugins/org.jboss.tools.hibernate.runtime.common/src/org/jboss/tools/hibernate/runtime/common/Util.java#L42
> why are these not turned into actual RuntimeExceptions and raised ?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)