[jbosstools-issues] [JBoss JIRA] (JBIDE-20090) composite dir regen includes empty folders and breaks p2

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079907#comment-13079907 ] 

Nick Boldt commented on JBIDE-20090:
------------------------------------

Note: this PR doesn't add a check that the /all/repo/ folder is a VALID update site, only that:

a) if the ssd folder is empty, we delete it, and 
b) if the ssd/childFolderSuffix/ isn't found, we don't add it to the composite. So for the specific failures from today, wherein these folders exist but are empty, this should work around it until we can figure out WHY the empty folders are being produced. 

http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-server_master/2015-06-12_17-51-19-B785/
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-server_4.3.mars/2015-06-12_14-08-09-B24/

http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-livereload_4.3.mars/2015-06-04_16-36-03-B17/
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-livereload_master/2015-06-12_05-22-45-B344/

http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-openshift_4.3.mars/2015-06-10_14-28-33-B24/
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-openshift_master/2015-06-10_14-22-56-B833/

http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-portlet_master/2015-06-11_05-26-17-B373/
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-playground_4.3.mars/2015-06-08_10-35-06-B7/
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-freemarker_4.3.mars/2015-06-11_11-31-22-B6/
...

This is really pervasive. But only seems to affect some jobs.


> composite dir regen includes empty folders and breaks p2
> --------------------------------------------------------
>
>                 Key: JBIDE-20090
>                 URL: https://issues.jboss.org/browse/JBIDE-20090
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Blocker
>             Fix For: 4.3.0.Beta1
>
>
> When we regen composite sites automatically, it includes subfolders but doesn't check if those folders are empty; so we should remove children if they're empty, and delete the folders too.
> We could also ensure that the child folder contains a folder that matches the $\{childFolderSuffix} (often /all/repo/).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)