[jbosstools-issues] [JBoss JIRA] (JBIDE-19757) Use jbosstools aggregate site instead of special webtools-site for WTP's AS server discovery

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083011#comment-13083011 ] 

Nick Boldt commented on JBIDE-19757:
------------------------------------

For comparison, I just installed the JBossAS server adapters into Luna. It took about 5 seconds to resolve and a total of 35 seconds to install. Footprint on disk was 13M. 

So... we're marginally slower to read metadata, but we're installing slightly less so it's only about 10 extra seconds of user time. 

Therefore unless [~maxandersen] [~rob.stryker] or [~mickael_istria] feel we should keep the webtools-site around, I think we're good to migrate to using the JBT site. 

> Use jbosstools aggregate site instead of special webtools-site for WTP's AS server discovery
> --------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19757
>                 URL: https://issues.jboss.org/browse/JBIDE-19757
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build, server
>            Reporter: Mickael Istria
>            Assignee: Nick Boldt
>            Priority: Minor
>              Labels: releasework
>             Fix For: 4.3.0.Beta1
>
>
> With https://bugs.eclipse.org/bugs/show_bug.cgi?id=434185 , WTP Server Discovery mechanism was granted a new strategy which allows to rely on regular p2 metadata instead of a site.xml.
> Support for this was already merged in server ( https://github.com/jbosstools/jbosstools-server/commit/2d3cc63a9b67753ad92a7bbcda15e1d15b2e22a8 )
> In order to save an artifact to manage (the webtools p2 repository), we could use this mechanism and consider contributing directly the main JBT URL to webtools discovery.
> However, server discovery also keeps older strategies and since we produce invalid site.xml files, this is currently failing
> {code}
> !ENTRY org.eclipse.equinox.p2.updatesite 2 0 2015-05-04 09:40:58.088
> !MESSAGE Error parsing feature stream. The unique identifier or the version is null or empty for the State: "Category": unique identifier="minimal-json" version="null".
> {code}
> because we are lines specifying bundle but no version in the site.xml.
> [~nickboldt] What are those site.xml useful for? Could we get rid of them?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)