[jbosstools-issues] [JBoss JIRA] (JBIDE-19335) org.jboss.tools.runtime.ui.internal.wizard.DownloadRuntimeLicenseFragment fails with SWTError without browser available

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084773#comment-13084773 ] 

Max Rydahl Andersen commented on JBIDE-19335:
---------------------------------------------

inconsistent property - all explained in the PR - but putting it here for ref in case you missed it:

{quote}
if it is going to be there then follow the naming pattern/conventions we have elsewhere.

    lowercase
    "scoped" by package/feature

so that would be something like 'jbosstools.skip.browser.creation' even though I can see it seems in foundation there is already several variations; but lets not make it worse.

and since it is a boolan it should not accept skipBrowserCreation=false
{quote}

mixed license text - you answered "Good catch" on the PR (see https://github.com/jbosstools/jbosstools-base/pull/419#discussion-diff-33310222R316) so sounds like you agreed with me there - what changed ?

no tests - this issue talks about a specific error situation, can that not be tested for ? many plugins now have swtbot tests for several years so can look for that. 

> org.jboss.tools.runtime.ui.internal.wizard.DownloadRuntimeLicenseFragment fails with SWTError without browser available
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19335
>                 URL: https://issues.jboss.org/browse/JBIDE-19335
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: common/jst/core, runtime-detection
>    Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
>         Environment: Linux
>            Reporter: Denis Golovin
>            Assignee: Rob Stryker
>             Fix For: 4.3.0.Beta2
>
>
> DownloadRuntimeLicenseFragment  should work even without browser widget available and show html or text without html tags with <p> and <br> elements replaced with '\n'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)