[jbosstools-issues] [JBoss JIRA] (JBIDE-18911) allow URL in the form "from-code=git at github.com" for custom app source code and downloadable cartridges

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049029#comment-13049029 ] 

Andre Dietisheim edited comment on JBIDE-18911 at 3/11/15 12:15 PM:
--------------------------------------------------------------------

* *The subtasks*:
*# The bugzilla that's related to this jira issue was asking for 1 thing: being able to use custom application template source code using an ssh url:
{code}
rhc app create kitchensink jbossas-7 mysql-5.5 -g small --from-code=git at github.com:openshift/kitchensink-example.git
{code}
*# Additionally this jira tried also to allow ssh-urls for downloadable (standalone- and embeddable-) cartridges. 
* *The state of the sub-tasks*:
*# Seems implemented, the ssh-url is passed over to OpenShift 
as provided in the UI:
!source-code.png!
OpenShift then tries to clone the source from the given ssh-url. In OpenShift Online this then of course fails because we cannot give it the private key for the public key that we registered in github. 
!clone-error.png!
If using OpenShift Enterprise we need to have this private key available on the broker host at /root/.ssh/ (see https://bugzilla.redhat.com/show_bug.cgi?id=1163964#c0)
{quote}
The reason why John could pass in comment 3, that is because he is using devenv, in the devenv instance, there is always ssh private key saved in /root/.ssh/, so when connecting to github via ssh protocol, node will use this private key to connect github by default, so git clone will always pass
{quote}
[~mlabuda] can you please organize a DEVENV where you have root access and can copy some private key to /root/.ssh/ and register the public key in github.
*# Is implemented for the UI validation only. OSJC wont accept the given ssh-url since it's not a valid URL and pass *null* over to OpenShift as shown above (https://issues.jboss.org/browse/JBIDE-18911?focusedCommentId=13043216&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13043216).


was (Author: adietish):
* *The subtasks*:
# The bugzilla that's related to this jira issue was asking for 1 thing: being able to use custom application template source code using an ssh url:
{code}
rhc app create kitchensink jbossas-7 mysql-5.5 -g small --from-code=git at github.com:openshift/kitchensink-example.git
{code}
# Additionally this jira tried also to allow ssh-urls for downloadable (standalone- and embeddable-) cartridges. 




* *The state of the sub-tasks*:
# Seems implemented, the ssh-url is passed over to OpenShift 
as provided in the UI:
!source-code.png!
OpenShift then tries to clone the source from the given ssh-url. In OpenShift Online this then of course fails because we cannot give it the private key for the public key that we registered in github. 
!clone-error.png!
If using OpenShift Enterprise we need to have this private key available on the broker host at /root/.ssh/ (see https://bugzilla.redhat.com/show_bug.cgi?id=1163964#c0)
{quote}
The reason why John could pass in comment 3, that is because he is using devenv, in the devenv instance, there is always ssh private key saved in /root/.ssh/, so when connecting to github via ssh protocol, node will use this private key to connect github by default, so git clone will always pass
{quote}
[~mlabuda] can you please organize a DEVENV where you have root access and can copy some private key to /root/.ssh/ and register the public key in github.
# Is implemented for the UI validation only. OSJC wont accept the given ssh-url since it's not a valid URL and pass *null* over to OpenShift as shown above (https://issues.jboss.org/browse/JBIDE-18911?focusedCommentId=13043216&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13043216).

> allow URL in the form "from-code=git at github.com" for custom app source code and downloadable cartridges
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-18911
>                 URL: https://issues.jboss.org/browse/JBIDE-18911
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.2.0.Final
>            Reporter: Andre Dietisheim
>            Assignee: Max Rydahl Andersen
>              Labels: application_wizard, embed_wizard, new_and_noteworthy
>             Fix For: 4.2.3.CR1
>
>         Attachments: clone-error.png, source-code.png
>
>
> We should be able to use urls that refer to github repositories when using custom application source code and downloadable cartridges
> The exact form is documented in the github (and general purpose git-) documentation: https://gist.github.com/grawity/4392747
> {quote}
> SSH, aka git at github.com: or ssh://git@github.com/
> {quote} 



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)