[jbosstools-issues] [JBoss JIRA] (JBIDE-19756) jbosstools-src.zip has incomplete/misleading version info in folder names/structure

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065874#comment-13065874 ] 

Nick Boldt commented on JBIDE-19756:
------------------------------------

Two problems with your plan:

a) zips are produced as snapshots, then later renamed ONLY if they're deemed QE-worthy. Your scheme would require *renaming the root folder inside the zip* as well as the zip itself. That would mean unpacking and repacking it as part of the "staging for QE" process. *-100* for that. That would mean changing the artifact between CI build and QE-stage, then again for release. 

Or, you'd have ALL the zips that lead up to 4.3.0.Final have the same root folder in them, whether they're Beta, CR, or Final. Are you OK with this?

*  jbosstools-<snapshot-qualifier>-src.zip!/jbosstools-4.3.0.Final-sources/
*  jbosstools-4.3.0.Beta1-src.zip!/jbosstools-4.3.0.Final-sources/
*  jbosstools-4.3.0.Beta1-src.zip!/jbosstools-4.3.0.Final-sources/
*  jbosstools-4.3.0.CR1-src.zip!/jbosstools-4.3.0.Final-sources/
*  jbosstools-4.3.0.Final-src.zip!/jbosstools-4.3.0.Final-sources/

I'm not, but you might prefer that to just having this:

*  jbosstools-4.3.0.CR1-src.zip!/jbosstools-sources/

b) for JBDS, you've selected a name that differs from the standard. 

Convention for JBDS (and other products) is to use *-src.zip*, not -sources.zip. Happy to provide examples if you need proof.



> jbosstools-src.zip has incomplete/misleading version info in folder names/structure
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-19756
>                 URL: https://issues.jboss.org/browse/JBIDE-19756
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta1
>
>         Attachments: jbide19756.png
>
>
> Downloading latest jbosstools-src.zip from http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.site_master/latest/all/jbosstools-src.zip I see multiple files in root named:
> <componentname>_<buildqualifier>_<sha1>
> example: 
> jbosstools-javaee_Beta1-v20150501-0413-B767_149f9a46d5c676fd7119515e8b6aa796859955ad
> A few issues with this:
> a) it would have been nice unzipping would not create multiple root level folders. Maybe have a jbosstools-source folder as root ? 
> b) the buildqualifier is there but the version string for the component is not. Either put the full version string for that component (not overall jbosstools version) or just leave it as <component>-<sha> and have the root folder state the full version of jbosstools. since non-indulged user would not know this one had to do with 4.3.0.Beta1 or 4.2.3.Beta1 (for example).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)