[jbosstools-issues] [JBoss JIRA] (JBIDE-19756) jbosstools-src.zip has incomplete/misleading version info in folder names/structure

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066316#comment-13066316 ] 

Nick Boldt commented on JBIDE-19756:
------------------------------------

How about this?

* jbosstools-4.3.0.Beta1-2015-05-07_09-32-54-B9842-src.zip!/jbosstools-4.3.0.Beta1-src/ (a snapshot in master branch)
* jbosstools-4.3.0.Beta1-2015-06-01_12-32-54-B48-src.zip!/jbosstools-4.3.0.Beta1-src/ (a snapshot in the future Beta1x branch)

So, the zip file contains the more detailed qualifier to differentiate it from subsequent CI builds, but the FOLDER inside is defined simply by the x.y.z.BUILD_ALIAS.

Does that work for you? Or do you want the root folder to include the full qualifier? 

--

Where using BUILD_ALIAS inside the zip could be a problem is when we move from CR1 to Final *without having to rebuild*, such as for service releases where CRs are not released.

In such a case, we would have:

* jbosstools-4.3.1.CR1-2015-12-01_12-32-54-B98-src.zip!/jbosstools-4.3.1.CR1-src/ (a snapshot in the future 4.3.x branch)

and need to be adjusted by hand or simply rebuilt to be called:

* jbosstools-4.3.1.Final-2015-12-01_12-32-54-B98-src.zip!/jbosstools-4.3.1.Final-src/ (a snapshot in the future 4.3.x branch)

If we omit the BUILD_ALIAS from the root folder, we wouldn't need to rebuild or unpack-and-repack these zips to replace s/CR1/Final.

So...

would this work?

* jbosstools-4.3.0.Beta1-2015-05-07_09-32-54-B9842-src.zip!/jbosstools-4.3.0-src/ (a snapshot in master branch)
* jbosstools-4.3.0.Beta1-2015-06-01_12-32-54-B48-src.zip!/jbosstools-4.3.0-src/ (a snapshot in the future Beta1x branch)

and for a rename-without-releasing-CR1 case:

* jbosstools-4.3.1.CR1-2015-12-01_12-32-54-B98-src.zip!/jbosstools-4.3.1-src/ (a snapshot in the future 4.3.x branch)
* jbosstools-4.3.1.Final-2015-12-01_12-32-54-B98-src.zip!/jbosstools-4.3.1-src/ (a snapshot in the future 4.3.x branch)


> jbosstools-src.zip has incomplete/misleading version info in folder names/structure
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-19756
>                 URL: https://issues.jboss.org/browse/JBIDE-19756
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta1
>
>         Attachments: jbide19756.png
>
>
> Downloading latest jbosstools-src.zip from http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.site_master/latest/all/jbosstools-src.zip I see multiple files in root named:
> <componentname>_<buildqualifier>_<sha1>
> example: 
> jbosstools-javaee_Beta1-v20150501-0413-B767_149f9a46d5c676fd7119515e8b6aa796859955ad
> A few issues with this:
> a) it would have been nice unzipping would not create multiple root level folders. Maybe have a jbosstools-source folder as root ? 
> b) the buildqualifier is there but the version string for the component is not. Either put the full version string for that component (not overall jbosstools version) or just leave it as <component>-<sha> and have the root folder state the full version of jbosstools. since non-indulged user would not know this one had to do with 4.3.0.Beta1 or 4.2.3.Beta1 (for example).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)