[jbosstools-issues] [JBoss JIRA] (JBIDE-19605) Avoid need for multiple javax.servlet

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066904#comment-13066904 ] 

Nick Boldt edited comment on JBIDE-19605 at 5/11/15 9:47 AM:
-------------------------------------------------------------

Yes, there's no point backporting this to 4.2.x until we plan to DO another 4.2.x release (eg., 4.2.4). Fix for master branch (4.3.0.Beta1):

https://github.com/jbosstools/jbosstools-webservices/pull/234


was (Author: nickboldt):
Yes, there's no point backporting this to 4.2.x until we plan to DO another 4.2.x release (eg., 4.2.4). Fix for master branch (4.3.0.Beta1), please. 



> Avoid need for multiple javax.servlet
> -------------------------------------
>
>                 Key: JBIDE-19605
>                 URL: https://issues.jboss.org/browse/JBIDE-19605
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: target-platform, webservices
>    Affects Versions: 4.3.0.Alpha2
>            Reporter: Mickael Istria
>            Assignee: Brian Fitzpatrick
>             Fix For: 4.3.0.Beta1
>
>         Attachments: org.jboss.tools.ws.jaxrs.core.internal.metamodel.builder.JavaElement11ChangedProcessingTestCase.txt, org.jboss.tools.ws.jaxrs.core.internal.metamodel.builder.JaxrsMetamodelChangedProcessorTestCase.txt, org.jboss.tools.ws.jaxrs.core.internal.metamodel.builder.ResourceChangedProcessingTestCase.txt, org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.Jaxrs11ElementFactoryTestCase.txt, org.jboss.tools.ws.jaxrs.core.internal.metamodel.domain.Jaxrs20EndpointTestCase.txt
>
>
> We currently use 2 different version of javax.servlet bundle. We'd rather decide on sticking to 1.
> {code}
> On 04/15/2015 11:56 PM, Nick Boldt wrote:
> > Just wondering if anyone knows WHY we include javax.servlet 3.0.0 and 
> > 3.1.0 in JBDS.
> > More importantly... SHOULD we be including both? Or can we just include 
> > 3.1.0 and drop 3.0.0?
> I have JBDS installed from installer, which basically ran a p2 director. And I get jetty 3.0.0 and jetty 3.1.0. Than means that while resolving what to installed, p2 has to keep both versions of javax.servlet. That's definitely a sign that our dependency chain currently need both (or p2 wouldn't have installed both).
> So I've tried the ultimate test:
> $ cd jbdevstudio-9.0.0.Alpha2/studio
> $ rm plugins/javax.servlet_3.0.0*
> $ ./jbdevstudio
> And saw
> !ENTRY org.jboss.tools.ws.ui 4 0 2015-04-16 10:35:49.110
> !MESSAGE FrameworkEvent ERROR
> !STACK 0
> org.osgi.framework.BundleException: Could not resolve module: org.jboss.tools.ws.ui [967]
>   Unresolved requirement: Import-Package: javax.servlet; version="[2.4.0,3.0.0)"
>     at org.eclipse.osgi.container.Module.start(Module.java:434)
>     at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1582)
>     at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1561)
>     at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1533)
>     at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1476)
>     at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
>     at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
>     at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
> Fun thing is that the javax.servlet_3.0.0 actually exports packages in version 2.6.0, whereas javax.servlet_3.1.0 exports them in version 3.1.0.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)