[jbosstools-issues] [JBoss JIRA] (JBIDE-19756) jbosstools-src.zip has incomplete/misleading version info in folder names/structure

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067763#comment-13067763 ] 

Nick Boldt edited comment on JBIDE-19756 at 5/13/15 11:04 AM:
--------------------------------------------------------------

mojo in JBT used to fetch sources from update site is different from what's (currently) used in JBDS. I could look at porting from the old ant script to the new mojo, so we'd fetch sources from github for jbdevstudio-product. HOWEVER... that would require the build store authorized credentials to access jbdevstudio-product (or pass them in commandline when building locally). Also, where JBT aggregate is simply an aggergation of 17 upstream projects, JBDS aggregate also includes the LOCAL sources for the com.jboss.devstudio.* IUs. 

So, instead of reusing the JBT mojo, I simply fetch the upstream zip from JBT build and merge its contents into the JBDS sources zip (contains a zip of what was just used to build JBDS updates/installer).

As a result, I can control the dir structure to be whatever you want. Do you want this?

* jboss-devstudio-9.0.0.Beta1-installer-src/
** jbdevstudio-product-SHA/
** jbosstools-*-SHA/ (17 folders)

Re: including buildinfo.json - see https://issues.jboss.org/browse/JBIDE-19798 ... you missed my questions above about including them, so I've moved them to the new JIRA.


was (Author: nickboldt):
mojo in JBT used to fetch sources from update site is different from what's (currently) used in JBDS. I could look at porting from the old ant script to the new mojo, so we'd fetch sources from github for jbdevstudio-product. HOWEVER... that would require the build store authorized credentials to access jbdevstudio-product (or pass them in commandline when building locally). Also, where JBT aggregate is simply an aggergation of 17 upstream projects, JBDS aggregate also includes the LOCAL sources for the com.jboss.devstudio.* IUs. 

So, instead of reusing the JBT mojo, I simply fetch the upstream zip from JBT build and merge its contents into the JBDS sources zip (contains a zip of what was just used to build JBDS updates/installer).

As a result, I can control the dir structure to be whatever you want. Do you want this?

* jboss-devstudio-9.0.0.Beta1-installer-src/
    * jbdevstudio-product-SHA/
    * jbosstools-*-SHA/ (17 folders)

Re: including buildinfo.json - see https://issues.jboss.org/browse/JBIDE-19798 ... you missed my questions above about including them, so I've moved them to the new JIRA.

> jbosstools-src.zip has incomplete/misleading version info in folder names/structure
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-19756
>                 URL: https://issues.jboss.org/browse/JBIDE-19756
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta1
>
>         Attachments: jbide19756.png, jbide19756_jbds-sources-zip.png, jbide19756_new_subfolders_and_zipfile_name.png
>
>
> Downloading latest jbosstools-src.zip from http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.site_master/latest/all/jbosstools-src.zip I see multiple files in root named:
> <componentname>_<buildqualifier>_<sha1>
> example: 
> jbosstools-javaee_Beta1-v20150501-0413-B767_149f9a46d5c676fd7119515e8b6aa796859955ad
> A few issues with this:
> a) it would have been nice unzipping would not create multiple root level folders. Maybe have a jbosstools-source folder as root ? 
> b) the buildqualifier is there but the version string for the component is not. Either put the full version string for that component (not overall jbosstools version) or just leave it as <component>-<sha> and have the root folder state the full version of jbosstools. since non-indulged user would not know this one had to do with 4.3.0.Beta1 or 4.2.3.Beta1 (for example).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)