[jbosstools-issues] [JBoss JIRA] (JBIDE-19798) include buildinfo.json files inside source zips

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067839#comment-13067839 ] 

Max Rydahl Andersen commented on JBIDE-19798:
---------------------------------------------

I do not follow how output of one mojo is input to another mojo is a problem.

That is how almost all mojo's work. The compiler mojo produces .class files that the assembly mojo packages up.

And these are called even in completely different projects and at different times so not following at all what the problem is.

if we can not safely ensure the consistency of buildinfo.json matches what we build/gather for source zips then we got a bigger and very different problem.

> include buildinfo.json files inside source zips
> -----------------------------------------------
>
>                 Key: JBIDE-19798
>                 URL: https://issues.jboss.org/browse/JBIDE-19798
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>            Reporter: Nick Boldt
>
> Max asked: {quote}
> [W]here are the build-info.json files to provide the info you were initially partially encoding into the file names ? 
> {quote}
> I replied: {quote}
> Adding json files will take more work as they're produced in a different mojo (GenerateRepositoryFacadeMojo.java, not FetchSourcesFromManifests.java), and I'm a bit hesitant to have one mojo depend on another.
> Do you want that the FetchSourcesFromManifests will also FetchJSONFromUpstreamLatestBuildsFolders (hoping that no respins have happened between the start of the aggregate job and the time when the fetch starts) ? Or should I just include target/fullSite/all/repo/buildinfo.json into target/fullSite/all/jbosstools-src.zip ?
> It's already included in the generated update site + update site zip, so I don't have a problem adding it to the src.zip too... except for the fact that we'll have cross-mojo dependencies. This will mean that the aggregate builds (JBT & JBDS) will depend on BOTH mojos, and that they can only be configured to run in a SPECIFIC order. Is that acceptable?
> {quote}
> (From JBIDE-19756)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)