[jbosstools-issues] [JBoss JIRA] (JBIDE-19757) Use jbosstools aggregate site instead of special webtools-site for WTP's AS server discovery

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068134#comment-13068134 ] 

Nick Boldt commented on JBIDE-19757:
------------------------------------

Versioning the symlink is entirely possible, and we do it today. Here are 3 versions of symlinks for mars and luna:

https://github.com/jbosstools/jbosstools-download.jboss.org/blob/jbosstools-4.3.0.Alpha2/jbosstools/updates/webtools/mars [tag]
https://github.com/jbosstools/jbosstools-download.jboss.org/blob/jbosstools-4.3.0.Alpha1x/jbosstools/updates/webtools/mars [branch]
https://github.com/jbosstools/jbosstools-download.jboss.org/blob/jbosstools-4.2.x/jbosstools/updates/webtools/luna [branch]

Hard to maintain? Well, as I said, it's 1 file vs. 2. I've done both approaches and have chosen the one I prefer. You don't have to worry about the maintenance of the link (be it composite or sym). The ONLY reason to use composite (with higher maintenance cost) vs. symlink is, as I said, above:

{quote}
If you can prove there's performance gain by using a composite instead of a symlink, then I will agree with you that your approach is better than mine. 
{quote}

Want to convince me? Use science to prove your opinion. :D



> Use jbosstools aggregate site instead of special webtools-site for WTP's AS server discovery
> --------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19757
>                 URL: https://issues.jboss.org/browse/JBIDE-19757
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build, server
>            Reporter: Mickael Istria
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta1
>
>
> With https://bugs.eclipse.org/bugs/show_bug.cgi?id=434185 , WTP Server Discovery mechanism was granted a new strategy which allows to rely on regular p2 metadata instead of a site.xml.
> Support for this was already merged in server ( https://github.com/jbosstools/jbosstools-server/commit/2d3cc63a9b67753ad92a7bbcda15e1d15b2e22a8 )
> In order to save an artifact to manage (the webtools p2 repository), we could use this mechanism and consider contributing directly the main JBT URL to webtools discovery.
> However, server discovery also keeps older strategies and since we produce invalid site.xml files, this is currently failing
> {code}
> !ENTRY org.eclipse.equinox.p2.updatesite 2 0 2015-05-04 09:40:58.088
> !MESSAGE Error parsing feature stream. The unique identifier or the version is null or empty for the State: "Category": unique identifier="minimal-json" version="null".
> {code}
> because we are lines specifying bundle but no version in the site.xml.
> [~nickboldt] What are those site.xml useful for? Could we get rid of them?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)