[jbosstools-issues] [JBoss JIRA] (JBIDE-19800) use maven to generate zip and jar md5/sha1 digests at build time instead of when publishing

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069469#comment-13069469 ] 

Max Rydahl Andersen commented on JBIDE-19800:
---------------------------------------------

for the record, that was not a +1 just a "hey - that looks like a great thing".

I haven't tried/tested this and didn't see the corresponding removal of what we used before ? is that somewhere ? 

I've added comments to both PR's. Main gist is that 

A) why use 1.3-snapshot if there is a release ? 
B) why repeat the version 5+ places, put it in parent pom plugin management section ?
C) PR's seem to include additional fixes beyond md5/sha1 changes.

fixing/clarifying the above would make it a +1.

> use maven to generate zip and jar md5/sha1 digests at build time instead of when publishing
> -------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19800
>                 URL: https://issues.jboss.org/browse/JBIDE-19800
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Beta1
>
>
> [~maxandersen] said: {quote}
> That we even have bash code for creating md5sum when maven supports it natively is for me the weird part (http://nicoulaj.github.io/checksum-maven-plugin/index.html)
> {quote} -- JBIDE-13835



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)