[jbosstools-issues] [JBoss JIRA] (JBIDE-19836) Migrate tests to use JUnit 4.12.0, not 3.8

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070573#comment-13070573 ] 

Max Rydahl Andersen commented on JBIDE-19836:
---------------------------------------------

thanks for the explanation [~nickboldt].
I always get suspicious when things like this is discovered so late.

I've opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=468098 to be sure Orbit actually intended to remove junit 3.8. Normally major versions in orbit stays "forever".

This change could also affect JBTIS thus we should ensure [~pleacu] is aware. In this case I reckon he can add back junit 3.8 if he needs it since it does not hurt us anyway.
 

> Migrate tests to use JUnit 4.12.0, not 3.8
> ------------------------------------------
>
>                 Key: JBIDE-19836
>                 URL: https://issues.jboss.org/browse/JBIDE-19836
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Blocker
>             Fix For: 4.3.0.Beta1
>
>
> The following files require JUnit 3.8.1 or 3.8.2, which are no longer in the Beta1 target platforms for JBT/JBDS (since Mars M7).
> {code}
> jbosstools-base/common/plugins/org.jboss.tools.common.text.xml/META-INF/MANIFEST.MF 
> jbosstools-base/common/tests/org.jboss.tools.common.base.test/META-INF/MANIFEST.MF 
> jbosstools-base/common/tests/org.jboss.tools.common.model.ui.test/META-INF/MANIFEST.MF 
> jbosstools-base/common/tests/org.jboss.tools.common.text.ext.test/META-INF/MANIFEST.MF 
> jbosstools-bpel/tests/org.jboss.tools.bpel.ui.test/META-INF/MANIFEST.MF 
> jbosstools-forge/tests/org.jboss.tools.forge.core.test/META-INF/MANIFEST.MF 
> jbosstools-forge/tests/org.jboss.tools.forge.ui.test/META-INF/MANIFEST.MF 
> jbosstools-hibernate/tests/org.hibernate.eclipse.console.test/META-INF/MANIFEST.MF 
> jbosstools-hibernate/tests/org.hibernate.eclipse.jdt.ui.test/META-INF/MANIFEST.MF 
> jbosstools-hibernate/tests/org.jboss.tools.hibernate.jpt.core.test/META-INF/MANIFEST.MF 
> jbosstools-hibernate/tests/org.jboss.tools.hibernate.ui.test/META-INF/MANIFEST.MF 
> jbosstools-javaee/cdi/tests/org.jboss.tools.cdi.text.ext.test/META-INF/MANIFEST.MF 
> jbosstools-javaee/jsf/tests/org.jboss.tools.jsf.vpe.jstl.test/META-INF/MANIFEST.MF 
> jbosstools-javaee/seam/tests/org.jboss.tools.seam.base.test/META-INF/MANIFEST.MF 
> jbosstools-jst/tests/org.jboss.tools.jst.jsp.base.test/META-INF/MANIFEST.MF 
> jbosstools-portlet/tests/org.jboss.tools.portlet.core.test/META-INF/MANIFEST.MF 
> jbosstools-vpe/tests/org.jboss.tools.vpe.base.test/META-INF/MANIFEST.MF 
> jbosstools-base/common/features/org.jboss.tools.common.all.test.feature/feature.xml 
> jbosstools-bpel/features/org.jboss.tools.bpel.test.feature/feature.xml 
> jbosstools-javaee/cdi/features/org.jboss.tools.cdi.deltaspike.test.feature/feature.xml 
> jbosstools-javaee/cdi/features/org.jboss.tools.cdi.seam.test.feature/feature.xml 
> jbosstools-javaee/cdi/features/org.jboss.tools.cdi.test.feature/feature.xml 
> jbosstools-javaee/cdi/tests/org.jboss.tools.cdi.core.test/pom.xml 
> jbosstools-javaee/jsf/tests/org.jboss.tools.jsf.vpe.jsf.test/resources/JBIDE5460TestProject/pom.xml 
> jbosstools-vpe/tests/org.jboss.tools.vpe.spring.test/resources/SpringTest/pom.xml 
> {code}
> Can these tests be updated to use JUnit 4.12.0?
> Currently, the coretests build [1] is failing with this error:
> {code}
> [ERROR]   Software being installed: org.jboss.tools.site.core.tests raw:4.3.0.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):4.3.0-SNAPSHOT
> [ERROR]   Missing requirement: org.jboss.tools.batch.test.feature.feature.group 1.7.0.Beta1-v20150520-2011-B779 requires 'org.junit [3.8.1,4.0.0)' but it could not be found
> {code}
> [1] https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.coretests-site_master/4370/console



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)