[jbosstools-issues] [JBoss JIRA] (JBIDE-19829) Add Oauth support to the Openshift Connection Wizard

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072479#comment-13072479 ] 

Andre Dietisheim commented on JBIDE-19829:
------------------------------------------

When tried to retrieve a token for http://openshift.redhat.com (which of course is the wrong server) I ended up having the following error: 

!retrieve-error.png!

and in the Eclipse log:
{code}
com.openshift.restclient.OpenShiftException: Client protocol exception while trying to get authorization context for server https://openshift.redhat.com
	at com.openshift.internal.restclient.authorization.AuthorizationClient.getContextUsingCredentials(AuthorizationClient.java:128)
	at com.openshift.internal.restclient.authorization.AuthorizationClient.getAuthorizationDetails(AuthorizationClient.java:74)
	at com.openshift.internal.restclient.DefaultClient.getAuthorizationDetails(DefaultClient.java:411)
	at org.jboss.tools.openshift.internal.ui.wizard.connection.OAuthDetailView$AuthDetailsJob.run(OAuthDetailView.java:236)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Caused by: org.apache.http.client.ClientProtocolException
	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:186)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:106)
	at com.openshift.internal.restclient.authorization.AuthorizationClient.getContextUsingCredentials(AuthorizationClient.java:123)
	... 4 more
Caused by: org.apache.http.ProtocolException: Received redirect response HTTP/1.1 404 Not Found but no location header
	at org.apache.http.impl.client.DefaultRedirectStrategy.getLocationURI(DefaultRedirectStrategy.java:134)
	at com.openshift.internal.restclient.authorization.OpenShiftAuthorizationRedirectStrategy.isRedirected(OpenShiftAuthorizationRedirectStrategy.java:58)
	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
	... 7 more
{code}

[~jcantrill] I guess we'll file this to a new issue?

> Add Oauth support to the Openshift Connection Wizard
> ----------------------------------------------------
>
>                 Key: JBIDE-19829
>                 URL: https://issues.jboss.org/browse/JBIDE-19829
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: openshift
>    Affects Versions: 4.3.0.Beta2
>            Reporter: Jeff Cantrill
>            Assignee: Jeff Cantrill
>         Attachments: Proposed Connection Wizard Chages.png, retrieve-error.png
>
>
> Modify the connection wizard so the v3 server can auto-detect the auth type and support OAuth
> * Remove server type verify button
> * Add v3 auth box (Auto/OAuth/Basic)
> * Optional...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)