[jbosstools-issues] [JBoss JIRA] (JBIDE-21005) Node / Bower / npm location should point to the node executable file instead of the parent folder of it

[Ilya Buziuk (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126934#comment-13126934 ] 

Ilya Buziuk commented on JBIDE-21005:
-------------------------------------

[~akazakov], So here is the result of my investigation about ${system_path:node / bower / npm }

1) Linux
 - Works fine assuming that node / bower / npm where preinstalled on the system 

2) Mac OS
- Works fine if eclipse was launched from the *terminal* only. For desktop launch those vars are not available

3) Windows
- Node detection works fine (points to *node.exe*). For npm and bower it gives not valid file for launch. Basically it points to bash node / npm scripts that are useless for windows, cause if we want to launch those tools directly (*without node*), on windows we will need *bower.cmd / npm.cmd*, and if we will will launch them via *node* the actuall nodejs scripts are required - */node_modules/npm/bin/npm-cli.js* & */node_modules/bower/bin/bower*

So, I do believe that the process of detection can be definitely improved, but in order to make a cq ASAP (who knows how much time the eclipse guys will need for approving it?) I propose to start it with the code that is in master right now. I guess [~psrna] would be able to test it on nightly and I will work on a brunch with contribution for *webtools.jsdt.core*. WDYT ?

> Node / Bower / npm location should point to the node executable file instead of the parent folder of it
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21005
>                 URL: https://issues.jboss.org/browse/JBIDE-21005
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: javascript, nodejs
>    Affects Versions: 4.3.0.Final
>            Reporter: Alexey Kazakov
>            Assignee: Ilya Buziuk
>             Fix For: 4.4.0.Alpha1
>
>
> Window->Preferences->Java Script tools->Node
> It's confusing that "Node Location" in that preference page is actually references to the parent folder of the executable node file. I would expect "/usr/bin/nodejs" or "C:/.../node.exe" in that field.
> IMO it's confusing and actually not very flexible. Why wouldn't let users to select the executable file itself?
> WDYT?



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)