[jbosstools-issues] [JBoss JIRA] (JBIDE-21092) Application wizard: Warn when a template points Source URL to a parameter with empty value

[Jeff Cantrill (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129193#comment-13129193 ] 

Jeff Cantrill commented on JBIDE-21092:
---------------------------------------

Because the source value is just a parameter like any other that is supported by the template, we can not validate for emptiness, only that it is required.  These parameters could be consumed by something like a deployment config which would pass that info to the resulting Docker image.  Empty values is a valid use case depending upon how the image author consumes them.  The parameter should either be marked required or the template author should accept they may get empty source values.

> Application wizard: Warn when a template points Source URL to a  parameter with empty value
> -------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21092
>                 URL: https://issues.jboss.org/browse/JBIDE-21092
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Jan Richter
>            Assignee: Andre Dietisheim
>              Labels: application_wizard, openshift_v3
>             Fix For: 4.3.1.Beta1
>
>
> If a template defines a parameter for Source URL {noformat}(i.e. Source_URL = ${GIT_URI}){noformat} but leaves it empty, the application wizard can be finished, but in the end the application creation fails because of the missing URL.
> It might be better to validate if the actual value passed is not empty.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)