[jbosstools-issues] [JBoss JIRA] (JBIDE-21116) XML Configuration and Filesets nodes leak to non-JBoss server adapters

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132244#comment-13132244 ] 

Rob Stryker commented on JBIDE-21116:
-------------------------------------

So after some investigation, I've found the following:

1) The nodes are opt-in, not opt-out. 
2) We automatically opt-in all org.eclipse.jst.*   inside ExtendedServerPropertiesAdapterFactory, for convenience
3) Openshift has opted in by providing an OpenShiftServerExtendedProperties class.  The OpenShiftServer implements IExtendedPropertiesProvider.  The OpenShiftServerExtendedProperties class can further opt out by overriding allowConvenienceEnhancements() and returning false.  This method is currently used only by the xml and fileset nodes. 

4) a number of smaller bugs were found with the functionality during this review:
   a)  two instances of "new Shell()" which used to function properly, now cause a blank shell window to appear somewhere uselessly. 
   b)  a bad iterator index  (loop always using result[0] instead of result[i])  means most auto-completion options are not showing
   c)  an NPE probably caused by a regression and insufficient testing causes autocomplete to fail entirely. 



> XML Configuration and Filesets nodes leak to non-JBoss server adapters
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-21116
>                 URL: https://issues.jboss.org/browse/JBIDE-21116
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: server
>    Affects Versions: 4.3.0.Final
>            Reporter: Fred Bricon
>
> The XML Configuration and Filesets nodes provided by JBoss Tools leak to non-JBoss server adapters.
> !http://content.screencast.com/users/fbricon/folders/Jing/media/be573a07-eff4-4c75-90a0-7334cabb0e09/00000228.png|width=450!
>  I find these confusing. After [~rob.stryker] explained me how they work, I can see some value in it, however, I think they should be added to non-JBoss servers on an opt-in basis.
> [~maxandersen] wdyt?



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)