[jbosstools-issues] [JBoss JIRA] (JBIDE-21121) Port Forwarding: Warning/error dialog should pop up if there is no oc binary when opening Port forwarding dialog

[Marián Labuda (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132726#comment-13132726 ] 

Marián Labuda commented on JBIDE-21121:
---------------------------------------

Ah, I found out what it is causing this issue. The problem is that if there is an invalid path for oc binary, port forwarding dialog does not take it into consideration and it fails only when Start All button is triggered. Upon canceling Workbench preference dialog any invalid value filled in oc binary path text widget should be cleared.

ASSERT: Have a OpenShift 3 connection with project in OpenShift Explorer View.
EXEC: Set incorrect path to OpenShift oc binary in preferences (type some invalid string or path non-leading to oc binary) and press Esc or close dialog.
EXEC: Create a new OpenShift 3 application (I created eap-basic s2i from server template)
ASSERT: Application is running (there is a succeeded pod for build called eap-app-1-build and there is a running pod with name eap-app-1-* where * is some string/hash)
EXEC: Select running pod and open its context menu.
EXEC: Select Port Forwarding... context menu.

RESULT: Dialog Application Port Forwarding is opened.
EXPECTED RESULT: Warning/Error dialog about oc should be shown.



> Port Forwarding: Warning/error dialog should pop up if there is no oc binary when opening Port forwarding dialog
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21121
>                 URL: https://issues.jboss.org/browse/JBIDE-21121
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Marián Labuda
>            Priority: Minor
>              Labels: openshift_v3, port_forwarding_wizard
>             Fix For: 4.4.0.Alpha1
>
>
> OpenShift 3 port forwarding features requires 'oc' binary to be set up in tooling. It's done in Workbench preference dialog on page OpenShift 3. If there is no 'oc' binary set and user invokes a port forwarding dialog, it is opened and even Start All button is enabled. User finds out that it is not possible to perform only when he gets an error message upon clicking on Start All button describing the problem. There could be some warning/error dialog popped up before opening a port forwarding dialog if there is no 'oc' location set in preferences.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)