[jbosstools-issues] [JBoss JIRA] (JBIDE-20900) why do we need both zip and tar.gz for org.jboss.tools.releng:jbosstools-releng-publish ?

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132734#comment-13132734 ] 

Nick Boldt commented on JBIDE-20900:
------------------------------------

My point is still that there's no need to publish BOTH zip and tar. Since one is better than two, we should remove one in favour of the other. 

In my experience, using source (the bash/csh/zsh built-in "." operator) is less safe because it attempts to read the script file from the local dir AND from the PATH.

http://stackoverflow.com/questions/24290726/file-execution-with-dot-space-versus-dot-slash

Plus, shell differences between OSes should be avoided. AFAIK, a chmod +x'd script run with ./ will always work, but sourcing it with "." isn't as reliable.

> why do we need both zip and tar.gz for org.jboss.tools.releng:jbosstools-releng-publish ?
> -----------------------------------------------------------------------------------------
>
>                 Key: JBIDE-20900
>                 URL: https://issues.jboss.org/browse/JBIDE-20900
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.0.Final, 4.4.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Minor
>             Fix For: 4.4.0.Alpha1
>
>
> When publishing, we use this:
> {code}
> [jbosstools-build-sites.aggregate.site_4.3.mars] $ /qa/tools/opt/apache-maven-3.2.5/bin/mvn -DTARGET_PLATFORM_VERSION=4.50.0.Final 
> -DTARGET_PLATFORM_VERSION_MAXIMUM=4.51.0.Final "-DMAVEN_FLAGS=-B -U -fae -e -P hudson,unified.target,pack200" 
> -DskipRevisionCheckWhenPublishing=true "-Dupdate.site.description=Stable Release" -Djbosstools_site_stream=4.3.mars -DtrimVersion=true 
> -Dmdep.stripClassifier=true -Dartifact=org.jboss.tools.releng:jbosstools-releng-publish:4.3.0.Final:zip 
> -DoutputDirectory=/mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_4.3.mars/sources 
> -Dmdep.stripVersion=true org.apache.maven.plugins:maven-dependency-plugin:2.9:unpack
> {code}
> But there's also this:
> {code}
> [INFO] Configured Artifact: org.jboss.tools.releng:jbosstools-releng-publish:4.3.0.Final:tar.gz
> [INFO] Downloading: https://repository.jboss.org/nexus/content/repositories/deprecated/org/jboss/tools/releng/jbosstools-releng-publish/4.3.0.Final/jbosstools-releng-publish-4.3.0.Final.tar.gz
> [INFO] Downloading: https://repository.jboss.org/nexus/content/groups/developer/org/jboss/tools/releng/jbosstools-releng-publish/4.3.0.Final/jbosstools-releng-publish-4.3.0.Final.tar.gz
> [INFO] Downloaded: https://repository.jboss.org/nexus/content/groups/developer/org/jboss/tools/releng/jbosstools-releng-publish/4.3.0.Final/jbosstools-releng-publish-4.3.0.Final.tar.gz (25 KB at 99.3 KB/sec)
> [INFO] Unpacking /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_4.3.mars/.repository/org/jboss/tools/releng/jbosstools-releng-publish/4.3.0.Final/jbosstools-releng-publish-4.3.0.Final.tar.gz to /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_4.3.mars/sources/aggregate/site/target/releng-scripts with includes "" and excludes ""
> [INFO] Expanding: /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_4.3.mars/.repository/org/jboss/tools/releng/jbosstools-releng-publish/4.3.0.Final/jbosstools-releng-publish-4.3.0.Final.tar.gz into /mnt/hudson_workspace/workspace/jbosstools-build-sites.aggregate.site_4.3.mars/sources/aggregate/site/target/releng-scripts{code}
> So... should we update jobs to fetch and use the .tar.gz because it retains exec perms? Then we can update the assembly.xml to only create the .tar.gz and stop wasting disk space w/ the extra zip.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)