[jbosstools-issues] [JBoss JIRA] (JBIDE-15332) why are skipRequirements controlling download of normal maven dependencies ?

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132909#comment-13132909 ] 

Nick Boldt commented on JBIDE-15332:
------------------------------------

PR has sat idle/ignored for a while now. Meanwhile we implemented skipTestsOrITests and did some refactoring of long-running ITests (the ones that depend on requirements). So... is this still needed? Or can we close / reject this? [~mickael_istria] [~rob.stryker] [~maxandersen] ?

> why are skipRequirements controlling download of normal maven dependencies ?
> ----------------------------------------------------------------------------
>
>                 Key: JBIDE-15332
>                 URL: https://issues.jboss.org/browse/JBIDE-15332
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>    Affects Versions: 4.2.0.Beta1
>            Reporter: Max Rydahl Andersen
>            Assignee: Mickael Istria
>            Priority: Minor
>              Labels: f2f2014
>             Fix For: LATER
>
>
> I stumbled on [~dgolovin]'s patch for livreload at https://github.com/jbosstools/jbosstools-livereload/pull/54/files
> This is not the first time i've seen skip having to be enabled for plain normal mvn dependencies.
> skipRequirements are supposed to only cover big downloads (like EAP, jboss etc.) - things done via non-maven download mechanism.
> Why is this applied to mvn dependency downloads ? 
> The culprit for needing this line is at:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L397
> and a bugzilla (*not* jira?!) is referenced as the reason for this back in 2012: https://github.com/jbosstools/jbosstools-build/commit/2e18baaf88e0cd73b3b99885658e00789e8fd198
> I understand why the explicit google download plugin (why is there two versions used btw?) but why is skipTests controlling normal mvn dependency download ? Which requirements are using this for download ?



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)