[jbosstools-issues] [JBoss JIRA] (JBIDE-15332) why are skipRequirements controlling download of normal maven dependencies ?
Nick Boldt (JIRA)
issues at jboss.org
Wed Nov 25 12:34:00 EST 2015
[ https://issues.jboss.org/browse/JBIDE-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133920#comment-13133920 ]
Nick Boldt commented on JBIDE-15332:
------------------------------------
In discussion today we decided we could:
1. ask on jbosstools-dev@ who, if anyone, needs to download upstream libraries/runtimes/jars using something like maven-dependency-plugin, and if they've already set <skip>false</skip> on those plugins' builds, eg., https://github.com/jbosstools/jbosstools-livereload/pull/54/
2. ask on jbosstools-dev@ who, if anyone, is using any of these variables:
* <swtbot.test.skip>true</swtbot.test.skip>
* <skipRequirements>${skipTests}</skipRequirements>
* <skipPrivateRequirements>true</skipPrivateRequirements>
* <skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements>
3. remove all the unneeded/unused skip*Requirements variables
4. dedupe the declaration of maven-download-plugin in parent pom ( https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L504-L522 )
> why are skipRequirements controlling download of normal maven dependencies ?
> ----------------------------------------------------------------------------
>
> Key: JBIDE-15332
> URL: https://issues.jboss.org/browse/JBIDE-15332
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Beta1
> Reporter: Max Rydahl Andersen
> Assignee: Mickael Istria
> Priority: Minor
> Labels: f2f2014
> Fix For: LATER
>
>
> I stumbled on [~dgolovin]'s patch for livreload at https://github.com/jbosstools/jbosstools-livereload/pull/54/files
> This is not the first time i've seen skip having to be enabled for plain normal mvn dependencies.
> skipRequirements are supposed to only cover big downloads (like EAP, jboss etc.) - things done via non-maven download mechanism.
> Why is this applied to mvn dependency downloads ?
> The culprit for needing this line is at:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L397
> and a bugzilla (*not* jira?!) is referenced as the reason for this back in 2012: https://github.com/jbosstools/jbosstools-build/commit/2e18baaf88e0cd73b3b99885658e00789e8fd198
> I understand why the explicit google download plugin (why is there two versions used btw?) but why is skipTests controlling normal mvn dependency download ? Which requirements are using this for download ?
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
More information about the jbosstools-issues
mailing list