[jbosstools-issues] [JBoss JIRA] (JBIDE-20912) Enable / Disable LiveReload settings have no effect for pages with already injected LiveReload.js

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115341#comment-13115341 ] 

Max Rydahl Andersen commented on JBIDE-20912:
---------------------------------------------

No, the browser live reload extension have no impact on the javascript already injected.

When I open a page with live reload included firefox live reload plugin does not show it is on - but it still live reloads.

Again, imagine if we just injected something called "dynamic-reload.js" instead - would you also expect the LiveReload extensions to be able to detect it ? IMO, no. and just because we inject javascript of the same name should not imply that live reload extensions to any browser can dynamically figure it out. 

> Enable / Disable LiveReload settings have no effect for pages with already injected LiveReload.js
> -------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-20912
>                 URL: https://issues.jboss.org/browse/JBIDE-20912
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: browsersim, cordovasim
>    Affects Versions: 4.3.0.CR2
>         Environment: JBDS 9.0.0.GA-v20151002-2235-B124, Fedora 22 KDE 64 bit, Oracle Java 1.8
>            Reporter: Vlado Pakan
>            Assignee: Ilya Buziuk
>             Fix For: 4.3.1.Final
>
>
> 1. Import HTML 5 project from JBoss Central
> 2. Run it on server
> 3. Open Server view, expand running server, select HTML 5 project, click on context menu 'Show In' > 'Web Browser via LiveReolad Server'
> ASSERT: index.html page is opened in system web browser
> 4. Copy link with index.html from system web broweer to Browsersim
> ASSERT: LiveReload is enabled in BrowserSim context menu
> 5. Open index.html page in VPE, change content and save it
> ASSERT: Changes are rendered in BrowserSim and system web browser
> 6. Disable LiveReload in BrowserSim context menu
> 7. change content of index.html and save it
> ASSERT: Changes are rendered in system web browser
> ERROR: Changes are rendered in BrowserSim (CordovaSim)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)