[jbosstools-issues] [JBoss JIRA] (JBIDE-20912) Enable / Disable LiveReload settings have no effect for pages with already injected LiveReload.js

[Vlado Pakan (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115571#comment-13115571 ] 

Vlado Pakan commented on JBIDE-20912:
-------------------------------------

It works exactly as I want with Google Chrome which is one of mostly used web browsers:

When user clicks on LiveReload extension icon in Chrome and disables the LiveReload page is not refreshed after changes are saved to page.

I don't understand problem with removing proper javascript file from displayed web page. We are injecting it when LvieReload is enabled in BrowserSim so why it's such a big problem to remove it especially when Chrome is able to handle it somehow.

We can also alter page send from server to inform BrowserSim that LiveReload javascript was injected to the page by our tooling so it's save to remove it I guess.

However I'm ok with rejecting this issue in case it's complicated even I don't see why it's so.

> Enable / Disable LiveReload settings have no effect for pages with already injected LiveReload.js
> -------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-20912
>                 URL: https://issues.jboss.org/browse/JBIDE-20912
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: browsersim, cordovasim
>    Affects Versions: 4.3.0.CR2
>         Environment: JBDS 9.0.0.GA-v20151002-2235-B124, Fedora 22 KDE 64 bit, Oracle Java 1.8
>            Reporter: Vlado Pakan
>            Assignee: Ilya Buziuk
>             Fix For: 4.3.1.Final
>
>
> 1. Import HTML 5 project from JBoss Central
> 2. Run it on server
> 3. Open Server view, expand running server, select HTML 5 project, click on context menu 'Show In' > 'Web Browser via LiveReolad Server'
> ASSERT: index.html page is opened in system web browser
> 4. Copy link with index.html from system web broweer to Browsersim
> ASSERT: LiveReload is enabled in BrowserSim context menu
> 5. Open index.html page in VPE, change content and save it
> ASSERT: Changes are rendered in BrowserSim and system web browser
> 6. Disable LiveReload in BrowserSim context menu
> 7. change content of index.html and save it
> ASSERT: Changes are rendered in system web browser
> ERROR: Changes are rendered in BrowserSim (CordovaSim)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)