[jbosstools-issues] [JBoss JIRA] (JBIDE-21001) Version of AngularJS in Central is older than version used in jbosstools-jst

[Alexey Kazakov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120750#comment-13120750 ] 

Alexey Kazakov commented on JBIDE-21001:
----------------------------------------

Thanks [~nickboldt] for the PRs.
I rebased and merged the 544 (master) but now I'm actually not sure we should use the EA site there. I like the idea to use the real EA site to download angularJS plugins for our tests. If we have incorrect version of angular then the test won't build. But we use different EA TPs during development and production and we should the correct one all the time in the pom.xml. So this approach will require frequent updates of the pom.xml, won't it? 
I also created two more PRs
https://github.com/jbosstools/jbosstools-jst/pull/546
https://github.com/jbosstools/jbosstools-jst/pull/547
to include angularjs plugins to the test environment. But we can't push them before https://github.com/jbosstools/jbosstools-discovery/pull/316 because currently the EA site has an old angularjs plugins 0.10.0 instead of the required 1.0

> Version of AngularJS in Central is older than version used in jbosstools-jst
> ----------------------------------------------------------------------------
>
>                 Key: JBIDE-21001
>                 URL: https://issues.jboss.org/browse/JBIDE-21001
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central, jsp/jsf/xml/html-source-editing
>    Affects Versions: 4.3.0.Final
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> Version of AngularJS used to build jbosstools-jst [1]:
> * 1.0.0.201508312121
> [1] https://github.com/jbosstools/jbosstools-jst/blob/jbosstools-4.3.x/pom.xml#L28
> Version of AngularJS (angularjs-eclipse-feature) included in Early Access site [2] for JBT 4.3.0.Final / JBDS 9.0.0.GA:
> * 0.10.0.201506182210
> [2] https://github.com/jbosstools/jbosstools-discovery/blob/jbosstools-4.3.x/jbtearlyaccesstarget/multiple/jbtearlyaccess-multiple.target#L11
> So, we should put the newer AngularJS in the EA site.
> But... it seems that the org.jboss.tools.jst.angularjs features & plugins don't actually depend on any of these:
> {code}
> org.eclipse.angularjs.ui_1.0.0.201508312121.jar
> org.eclipse.angularjs.core_1.0.0.201508312121.jar
> angularjs-eclipse-feature_1.0.0.201508312121.jar
> {code}
> So... other than the JBT/JBDS EA connectors, I can't see any reference to a specific version of angular, which begs the question: why does the jbosstools-jst build declare a dependency [3] on a specific update site mirror, such as [4] ?
> [3] https://github.com/jbosstools/jbosstools-jst/blob/jbosstools-4.3.x/pom.xml#L23-L29
> [4] http://download.jboss.org/jbosstools/updates/requirements/angularjs/1.0.0.201508312121/



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)