[jbosstools-issues] [JBoss JIRA] (JBIDE-19948) Reimplement Eclipse Download plugin to allow dynamic work flow

[David Hladky (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103973#comment-13103973 ] 

David Hladky commented on JBIDE-19948:
--------------------------------------

Hi Max, the current implementation is kinda broken. It was designed to be universal and the relatively easy to use, however the later additions to the communication protocol and the hard coded stuff made it complicated and barely maintainable on both sides. For example name of the file is added as a text field, the xml format is  on my side generated manually and therefore it is not suitable for easy parsing using RestEasy and similar frameworks and ohers..... 

A) I hoped [~rob.stryker] would have had the layouts prepared by today so the only thing left would have been would have been adding the communication part. I do not know how soon will the code freeze be, if it is this week or next week, I think it makes sense to postpone it to the next development phase. It is pity I was stuck with other critical stuff and blockers so I had time to start working on JBIDE-19948  on last Friday and not earlier as originally planned. 

B) I agree completely and we solved it with Rob. The plan was Rob will add version number as a query parameter to the request, which tells DM server part what format to use. No version number = old behaviour. version=1 would allow using the planned layouts and maybe sometime in future versions 2+ would allow more layouts if needed. 

C) We really need to make it simple and I think it is possible. Right now I am working on an artifact, that will be deployed to repository.jboss.org. It will contain classes for marshalling and un-marshalling using JAX-RS on both sides, which would simplify the thing quite a lot. Server side the old implementation will need to stay, but in DS the bad implementation should go away completely and the new one should be used instead. 

To make the thing easy the original idea of the stateless approach on side of the Eclipse plugin should be used. It is not difficult to have multiple independent components (in this case layouts) and simply pick the one, that matches its identifier. The current implementation has state smuggled into the plugin logic, which makes the whole thing complicated and it caused a lot of problems when I added the new TC model into the system. 
----
I will continue the work on the server part. The number 1 priority on my side is to prepare a document, that describes the new approach. When it is done, we can discuss it and possibly do adjustments to it to suite your needs best. I do not know, if we will be able to get the changes to the current DS release, but I now have working capacity for it so I will finish the server side to be ready for DS. 

> Reimplement Eclipse Download plugin to allow dynamic work flow
> --------------------------------------------------------------
>
>                 Key: JBIDE-19948
>                 URL: https://issues.jboss.org/browse/JBIDE-19948
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: runtime-detection, server
>    Affects Versions: 4.3.0.Alpha2
>            Reporter: David Hladky
>            Assignee: Rob Stryker
>             Fix For: 4.3.0.CR1
>
>
> We need to reimplement the plugin to accept new terms and conditions models as well as follow the workflow changes in case of changes to the current ones. 
> Under this issue I will create the tasks we need to achieve this goal. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)