[jbosstools-issues] [JBoss JIRA] (JBDS-3432) create verification test - JBDS update site(s) and installer should not contain <references> to external URLs

[Nick Boldt (JIRA)]

     [ https://issues.jboss.org/browse/JBDS-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Boldt closed JBDS-3432.
----------------------------
    Resolution: Done


Not sure we need to write a test here. Here's why...

When the JBDS update site is built, it calls `org.jboss.tools.tycho-plugins::repository-utils::package::generate-repository-facade`, which runs this:

{code:title=https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/repository-utils/src/main/java/org/jboss/tools/tycho/sitegenerator/GenerateRepositoryFacadeMojo.java#L459-L464}
					NodeList references = repoElement.getElementsByTagName("references");
					// remove default references
					for (int i = 0; i < references.getLength(); i++) {
						Node currentRef = references.item(i);
						currentRef.getParentNode().removeChild(currentRef);
					}
{code}

Then if the pom specifies any associate sites to add...

{code}
<associateSite>https://devstudio.redhat.com/9.0/stable/updates/</associateSite>
{code}

...  a NEW <references> tag is added, containing ONLY the new URL(s).

But otherwise, there are no references at this point.

So, closing. As long as we call `org.jboss.tools.tycho-plugins::repository-utils::package::generate-repository-facade` when building the update site, no external references will exist -- even references to JBT sites.


> create verification test - JBDS update site(s) and installer should not contain <references> to external URLs
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: JBDS-3432
>                 URL: https://issues.jboss.org/browse/JBDS-3432
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Sub-task
>          Components: build, installer, updatesite
>    Affects Versions: 9.0.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 9.0.0.CR1
>
>
> We ought to have some sort of maven-based verification test that can unpack the update site zip and installer, and verify that the p2 metadata doesn't reference any unexpected 3rd party URLs.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)