[jbosstools-issues] [JBoss JIRA] (JBIDE-20673) Arquillian deployment validation does not consider nested classes

[Alexey Kazakov (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-20673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Kazakov updated JBIDE-20673:
-----------------------------------
    Fix Version/s: 4.3.x
                       (was: 4.3.0.Final)


It doesn't look like critical for JBT 4.3.0.CR1 respin-a to me. So, moving to 4.3.x.
I assume this validation can be disabled as a workaround?

> Arquillian deployment validation does not consider nested classes
> -----------------------------------------------------------------
>
>                 Key: JBIDE-20673
>                 URL: https://issues.jboss.org/browse/JBIDE-20673
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: arquillian
>    Affects Versions: 4.3.0.Beta2
>            Reporter: Rich DiCroce
>            Assignee: Snjezana Peco
>             Fix For: 4.3.x
>
>
> The Arquillian plugin validates deployments to ensure they contain all of the classes that are referenced by the test. But the validation logic does not consider nested classes.
> I'm currently working on a patch for the Apache DeltaSpike project and decided to add a few tests. One test references a class object:
> {code:java}
>     @Test
>     public void testNoSecuredAnnotation()
>     {
>         testViewAccessHandlerMethods(Pages.NoSecurity.class, true, 0, 0);
>     }
> {code}
> The Arquillian plugin incorrectly flags the class name with this warning:
> {noformat}
> Arquillian: The org.apache.deltaspike.test.jsf.impl.config.view.security.Pages.NoSecurity type is not included in any deployment.
> {noformat}
> Changing the class to Pages.class removes the warning, so the plugin does know about that class, but is not noticing its nested classes. For reference, this is what Pages looks like:
> {code:java}
> interface Pages extends ViewConfig
> {
>     class NoSecurity implements ViewConfig
>     {
>     }
>     
>     @Secured(AlwaysSucceedsVoter.class)
>     class AlwaysSucceeds implements ViewConfig
>     {
>     }
>     
>     @Secured(AlwaysDeniedVoter.class)
>     class AlwaysDenied implements ViewConfig
>     {
>     }
>     
>     @Secured(AlwaysDeniedVoter.class)
>     interface DeniedFolder
>     {
>         
>         class InheritsDeniedFromFolder implements ViewConfig
>         {
>         }
>         
>         @Secured(AlwaysSucceedsVoter.class)
>         class CompositionWithFolder implements ViewConfig
>         {
>         }
>         
>     }
>     
>     @Secured(AlwaysDeniedVoter.class)
>     interface SuperConfig extends ViewConfig
>     {
>     }
>     
>     class InheritsDeniedFromSuper implements SuperConfig
>     {
>     }
>     
>     @Secured(AlwaysSucceedsVoter.class)
>     class CompositionWithSuper implements SuperConfig
>     {
>     }
>     
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)