[jbosstools-issues] [JBoss JIRA] (JBTIS-508) integration stack update sites mix discovery and earlyaccess causing inconsistent update mechanism

[Paul Leacu (JIRA)]

    [ https://issues.jboss.org/browse/JBTIS-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113985#comment-13113985 ] 

Paul Leacu commented on JBTIS-508:
----------------------------------

Okay - [~nickboldt] - if you have a chance - please review this PR (Max too if you'd like):

https://github.com/jbosstools/jbosstools-integration-stack/pull/438

I've update the jbosstools and devstudio discovery site generation to create separate released and earlyaccess JBoss Central discovery sites (no mixing of the streams).
For example - building like this:
{code}
mvn -B -U  \
    -DCOMPOSITE_URLS=http://download.jboss.org/jbosstools/mars/development/updates/core/,http://download.jboss.org/jbosstools/mars/integration/updates/integration-stack/4.3.0.Alpha2,http://download.jboss.org/jbosstools/targetplatforms/jbtistarget/4.3.0.Beta1f-SNAPSHOT/jbtis/REPO \
    -DCOMPOSITE_EA_URLS=http://download.jboss.org/jbosstools/mars/development/updates/core/,http://download.jboss.org/jbosstools/mars/integration/updates/integration-stack/4.3.0.Alpha2/earlyaccess,http://download.jboss.org/jbosstools/targetplatforms/jbtistarget/4.3.0.Beta1f-SNAPSHOT/jbtis/earlyaccess/REPO clean install
{code}
produces composites like this for released:
{code}
<?xml version='1.0' encoding='UTF-8'?>
<?compositeArtifactRepository version='1.0.0'?>
<repository name='JBoss Tools Integration Stack Central - composite staging site' type='org.eclipse.equinox.internal.p2.artifact.repository.CompositeArtifactRepository' version='1.0.0'>
  <properties size='2'>
    <property name='p2.timestamp' value='1443643601057'/>
    <property name='p2.compressed' value='true'/>
  </properties>
  <children size='3'>
  	<child location='http://download.jboss.org/jbosstools/mars/development/updates/core/'/>
  	<child location='http://download.jboss.org/jbosstools/mars/integration/updates/integration-stack/4.3.0.Alpha2'/>
  	<child location='http://download.jboss.org/jbosstools/targetplatforms/jbtistarget/4.3.0.Beta1f-SNAPSHOT/jbtis/REPO'/>
  </children>
</repository>
{code}
and this for early access:
{code}
<?xml version='1.0' encoding='UTF-8'?>
<?compositeArtifactRepository version='1.0.0'?>
<repository name='JBoss Tools Integration Stack Central - composite staging site' type='org.eclipse.equinox.internal.p2.artifact.repository.CompositeArtifactRepository' version='1.0.0'>
  <properties size='2'>
    <property name='p2.timestamp' value='1443643601510'/>
    <property name='p2.compressed' value='true'/>
  </properties>
  <children size='3'>
  	<child location='http://download.jboss.org/jbosstools/mars/development/updates/core/'/>
  	<child location='http://download.jboss.org/jbosstools/mars/integration/updates/integration-stack/4.3.0.Alpha2/earlyaccess'/>
  	<child location='http://download.jboss.org/jbosstools/targetplatforms/jbtistarget/4.3.0.Beta1f-SNAPSHOT/jbtis/earlyaccess/REPO'/>
  </children>
</repository>
{code}
The generated jbosstools-integration-stack-directory.xml for released:
{code}
<?xml version='1.0' encoding='UTF-8'?>
<directory xmlns="http://www.eclipse.org/mylyn/discovery/directory/">
<entry url="http://download.jboss.org/jbosstools/mars/development/updates/discovery.central/4.3.0.CR1/plugins/org.jboss.tools.central.discovery.earlyaccess_4.3.0.CR1-v20150918-1233-B121.jar" permitCategories="true"/>
<entry url="http://download.jboss.org/jbosstools/mars/development/updates/discovery.central/4.3.0.CR1/plugins/org.jboss.tools.central.discovery_4.3.0.CR1-v20150918-1233-B121.jar" permitCategories="true"/>
<entry url="plugins/org.jboss.tools.central.discovery.integration-stack_4.3.0.Alpha2-v20130101-0001-B1.jar" permitCategories="true"/>
</directory>
{code}
and the generated  jbosstools-integration-stack-directory.xml for early access:
{code}
<?xml version='1.0' encoding='UTF-8'?>
<directory xmlns="http://www.eclipse.org/mylyn/discovery/directory/">
<entry url="http://download.jboss.org/jbosstools/mars/development/updates/discovery.central/4.3.0.CR1/plugins/org.jboss.tools.central.discovery.earlyaccess_4.3.0.CR1-v20150918-1233-B121.jar" permitCategories="true"/>
<entry url="http://download.jboss.org/jbosstools/mars/development/updates/discovery.central/4.3.0.CR1/plugins/org.jboss.tools.central.discovery_4.3.0.CR1-v20150918-1233-B121.jar" permitCategories="true"/>
<entry url="plugins/org.jboss.tools.central.discovery.integration-stack.earlyaccess_4.3.0.Alpha2-v20130101-0001-B1.jar" permitCategories="true"/>
</directory>
{code}

Similar results for devstudio.  How these sites are merged with the parent JBT/JBDS discovery sites is next - but they need to be generated which is this PR.

WDYT?



> integration stack update sites mix discovery and earlyaccess causing inconsistent update mechanism
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBTIS-508
>                 URL: https://issues.jboss.org/browse/JBTIS-508
>             Project: JBoss Tools Integration Stack
>          Issue Type: Bug
>          Components: releng
>            Reporter: Max Rydahl Andersen
>            Assignee: Paul Leacu
>            Priority: Blocker
>
> While reviewing JBIDE-20803 I noticed the following:
> {code}
> jboss.discovery.site.integration-stack.url|jbosstools|4.2.4=http://download.jboss.org/jbosstools/discovery/stable/integration-stack/
> {code}
> The stable release for 4.2.4 is stated to point to the stable integration stack url which on surface looks good:
> But there are a few problems:
> 1) why not just point to http://download.jboss.org/jbosstools/updates/stable/luna/ and have the above internal detail url composited in ?
> 2) the actual composite behind it right now is http://download.jboss.org/jbosstools/discovery/stable/integration-stack/4.2.3.Final/compositeContent.xml which links in http://download.jboss.org/jbosstools/discovery/stable/integration-stack/4.2.3.Final/compositeContent.xml (our main sites should never composite earlyaccees since then when users install supported versions they suddenly will now also have access to earlyaccess.
> #1 is mainly just to reduce the number of updatesites actually necessary for users to work with
> #2 seems to be something inherent broken in the IS build since earlyaccess shold *never* be aggregated into the release site.
> Any earlyaccess connectors should explicitly point to a *separate* earlyaccess site.
> I would also have expected that the discovery site with the discovery plugins was kept *separate* from the actual update sites to avoid any coupling between these.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)